Upgrade OneSignal from v4 -> v5, hermes black magic, refactor one-signal.js -> one-signal.ts
#877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elransh
reviewed
May 15, 2025
danielmar121
approved these changes
May 15, 2025
ariel-weiss
changed the title
OneSignal from v4 -> v5, disable hermes, refactor one-signal.js -> one-signal.tsOneSignal from v4 -> v5, hermes black magic, refactor one-signal.js -> one-signal.ts
ofekrotem
reviewed
May 19, 2025
danielmar121
approved these changes
May 27, 2025
…AUT-24685-upgrade-one-signal-version-v-4-v-5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason for this PR is due to Apple's restriction of building apps w/ Xcode <16.x.
Once building with Xcode 16.2 we cannot have dependencies that use Bitcode, like
OneSignalv4 and the usage ofhermesin our Podfile with the currentreact-nativeversion.Since we need to make a lot of changes to the way we implement
OneSignal, I took the chance to refactor the service and convert it into TS.