-
Notifications
You must be signed in to change notification settings - Fork 820
Paid blocks upgrade nudge: fix spacing #43391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
|
||
.jetpack-upgrade-plan-banner .jetpack-upgrade-plan-banner__wrapper .components-button { | ||
flex-shrink: 0; | ||
line-height: 1; | ||
margin-left: auto; | ||
height: 28px; } | ||
margin: 10px 0 10px auto; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line is the only actual fix — the rest are whitespace fixes.
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Code Coverage SummaryThis PR did not change code coverage! That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷 |
Proposed changes:
Before

After

Mobile
Banner still needs improving but this is a start.
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions: