-
Notifications
You must be signed in to change notification settings - Fork 820
Donations block: Update to utilise formatCurrency from @automattic/number-formatters #43418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
…omattic/number-formatters
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Jetpack plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryThis PR did not change code coverage! That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷 |
Related to #43405 and #42796
Post-fix addressing #43401
Proposed changes:
The donations block is a fairly old and untyped implementation that also consumes an older version of
@automattic/format-currency
(1.0.0
, never updated to the latest2.0.0
). The implementation between the two versions differs, also, the older version doesn't readily migrate to@automattic/number-formatters
, which is now the only preferred way of formatting numbers and currencies (@automattic/format-currency
is being fully deprecated in Automattic/wp-calypso#100559) - for example, certain options are no longer supported (likesymbol
that renders a currency without a symbol if falsy - something that Donations block uses).This PR aims to re-attempt a migration to
@automattic/number-formatters
and should (along with #42457) complete the migration to the new package in Jetpack.Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions: