Skip to content

Conversation

@enejb
Copy link
Member

@enejb enejb commented Dec 9, 2025

Do not merge!

Screen.Recording.2025-12-08.at.5.00.42.PM.mov

Proposed changes:

  • Update the variation picker to create a new jetpack-form custom post type and add the ref attribute.
  • Store the whole form block on the custom post type.
  • Form innerblock as well as attributes get inherited from the custom post type.
  • Limit the number

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Enable feature flag:
    add_filter( 'jetpack_block_editor_feature_flags', function ( $features ) {
    	$features['reusable-forms'] = true;
    	return $features;
    } );
  • Add a new form on a page
  • Edit the form from within the form editor.

enejb added 5 commits December 4, 2025 11:52
Updated the jetpack-form post type to use 'post' as capability_type and enabled map_meta_cap for proper capability mapping. Enhanced the REST_Jetpack_Form_Controller with custom permissions checks for reading and creating forms. Added comprehensive PHPUnit tests for the reusable forms feature, including REST API endpoint coverage and capability checks.
@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the try/update-form-block-whole-block branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack try/update-form-block-whole-block

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • 🔴 Add a "[Status]" label (In Progress, Needs Review, ...).
  • 🔴 Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@github-actions github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Dec 9, 2025
@jp-launch-control
Copy link

jp-launch-control bot commented Dec 9, 2025

Code Coverage Summary

Cannot generate coverage summary while tests are failing. 🤐

Please fix the tests, or re-run the Code coverage job if it was something being flaky.

Full summary · PHP report · JS report

<div { ...blockProps }>
<Placeholder>
<Spinner />
{ __( 'Loading form...', 'jetpack-forms' ) }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{ __( 'Loading form...', 'jetpack-forms' ) }
{ __( 'Loading form', 'jetpack-forms' ) }


// Initialize Reusable Forms feature if enabled
$feature_flags = apply_filters( 'jetpack_block_editor_feature_flags', array() );
if ( ! empty( $feature_flags['reusable-forms'] ) ) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reusable-forms

We should probably find some other term to describe these in code that refers more to mechanism how they're stored or synced, rather than a feature.

@simison simison added the DO NOT MERGE don't merge it! label Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Block] Contact Form Form block (also see Contact Form label) DO NOT MERGE don't merge it! [Feature] Contact Form [Package] Forms [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. [Tests] Includes Tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants