-
Notifications
You must be signed in to change notification settings - Fork 844
Try: update form block - store the whole block #46233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
Updated the jetpack-form post type to use 'post' as capability_type and enabled map_meta_cap for proper capability mapping. Enhanced the REST_Jetpack_Form_Controller with custom permissions checks for reading and creating forms. Added comprehensive PHPUnit tests for the reusable forms feature, including REST API endpoint coverage and capability checks.
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
Code Coverage SummaryCannot generate coverage summary while tests are failing. 🤐 Please fix the tests, or re-run the Code coverage job if it was something being flaky. |
| <div { ...blockProps }> | ||
| <Placeholder> | ||
| <Spinner /> | ||
| { __( 'Loading form...', 'jetpack-forms' ) } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| { __( 'Loading form...', 'jetpack-forms' ) } | |
| { __( 'Loading form…', 'jetpack-forms' ) } |
|
|
||
| // Initialize Reusable Forms feature if enabled | ||
| $feature_flags = apply_filters( 'jetpack_block_editor_feature_flags', array() ); | ||
| if ( ! empty( $feature_flags['reusable-forms'] ) ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reusable-forms
We should probably find some other term to describe these in code that refers more to mechanism how they're stored or synced, rather than a feature.
Do not merge!
Screen.Recording.2025-12-08.at.5.00.42.PM.mov
Proposed changes:
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions: