Skip to content

Conversation

@keoshi
Copy link
Contributor

@keoshi keoshi commented Dec 10, 2025

Proposed changes:

  • Replace generic module activation success messages with benefit-driven messages that emphasize immediate value.
  • Create a new utility module with custom benefit messages for all 41 Jetpack modules.
  • Update the ModuleToggle component to display contextual benefits when features are activated (e.g., "Image CDN activated! Your site now loads images faster with automatic resizing from our global CDN.")
  • All benefit messages are fully translatable using WordPress i18n functions.
Before After
image image

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes
    do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so,
    you'll see a generated comment below with a script to run)?

Jetpack product discussion

p1765329939935419-slack-C0D96691V

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  1. Go to My JetpackProducts tab.
  2. Find any inactive module in the list (e.g., Image CDN, Downtime Monitor, Related Posts, etc.)
  3. Toggle the module ON.
  4. Confirm the success message emphasizes the value of that module.

Expected behavior:

  • Success message should follow the format: [Module name] activated! [Benefit].
  • Example for Image CDN: "Image CDN activated! Your site now loads images faster with automatic resizing from our global CDN."
  • The message should clearly communicate the immediate value/benefit of activating the feature.

Before:
Generic message: "Image CDN has been activated."

After:
Benefit-driven message: "Image CDN activated! Your site now loads images faster
with automatic resizing from our global CDN."

  1. Test with multiple different modules to verify each has a custom benefit message.
  2. Toggle a module OFF to verify deactivation messages still work correctly. Should show: "[Module name] has been deactivated.")

@keoshi keoshi self-assigned this Dec 10, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 10, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@github-actions github-actions bot added [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. and removed [Status] Needs Review This PR is ready for review. labels Dec 10, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 10, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the add/myjp-products-benefit-driven-activation-messages branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack add/myjp-products-benefit-driven-activation-messages

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@jp-launch-control
Copy link

jp-launch-control bot commented Dec 10, 2025

Code Coverage Summary

1 file is newly checked for coverage.

File Coverage
projects/packages/my-jetpack/_inc/utils/module-benefit-messages.ts 0/6 (0.00%) 💔

Full summary · PHP report · JS report

If appropriate, add one of these labels to override the failing coverage check: Covered by non-unit tests Use to ignore the Code coverage requirement check when E2Es or other non-unit tests cover the code Coverage tests to be added later Use to ignore the Code coverage requirement check when tests will be added in a follow-up PR I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage.

@keoshi keoshi added [Status] Needs Review This PR is ready for review. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Dec 10, 2025
@keoshi keoshi requested review from a team December 11, 2025 10:35
Copy link
Member

@manzoorwanijk manzoorwanijk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let us retain the interpolation we had before to make translation easier.

@keoshi
Copy link
Contributor Author

keoshi commented Dec 11, 2025

Thanks so much for the thorough review, @manzoorwanijk! Pushing some changes right now.

@keoshi keoshi requested a review from manzoorwanijk December 11, 2025 15:31
…checking

Adding type-checking caught 'custom-content-types' not being shown in the modules list.
@manzoorwanijk
Copy link
Member

I added type-checking for the module slug in the list of benefits. It immediately caught an issue that 'custom-content-types' was not being shown in the modules list anywhere on My Jetpack. Thus, I added it to the list.

manzoorwanijk
manzoorwanijk previously approved these changes Dec 12, 2025
Copy link
Member

@manzoorwanijk manzoorwanijk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works great. Thank you. Please let me know if you need help merging/deploying this.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances the My Jetpack user experience by replacing generic module activation success messages with benefit-driven messages that emphasize the immediate value users receive when activating features.

Key changes:

  • Created a new utility module (module-benefit-messages.ts) with custom benefit messages for all 43 Jetpack modules
  • Updated ModuleToggle component to use the new benefit-driven messages for module activation
  • Added custom-content-types module to the system (previously missing from the constants)

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
projects/packages/my-jetpack/changelog/add-myjp-products-benefit-driven-activation-messages Standard changelog entry documenting this feature enhancement
projects/packages/my-jetpack/_inc/utils/module-benefit-messages.ts New utility file containing 43 benefit-driven success messages and the activation message formatter function
projects/packages/my-jetpack/_inc/constants.ts Added custom-content-types module to the JETPACK_NON_PAID_MODULES array
projects/packages/my-jetpack/_inc/components/my-jetpack-tab-panel/products/mappings.ts Added custom-content-types module to the 'other' category for display in the products tab
projects/packages/my-jetpack/_inc/components/module-toggle/index.tsx Updated to use new getModuleActivationMessage() function and fixed dependency array

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

* The benefit messages use present-tense descriptions of what the user NOW has.
* Messages are interpolated as: "%1$s activated! %2$s" where %1$s is the module
* name and %2$s is the benefit message.
*
Copy link

Copilot AI Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description states "all 41 Jetpack modules" but there are actually 43 modules being covered (36 non-paid + 7 paid). Please update the PR description to reflect the correct count of 43 modules.

Suggested change
*
*
* Covers all 43 Jetpack modules (36 non-paid + 7 paid).

Copilot uses AI. Check for mistakes.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we missed any 🤔

I think we are fine here, since we have a fallback.

@keoshi
Copy link
Contributor Author

keoshi commented Dec 12, 2025

Thanks, @manzoorwanijk ! I think this should be finally ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

My Jetpack [Package] My Jetpack [Status] Needs Review This PR is ready for review. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants