-
Notifications
You must be signed in to change notification settings - Fork 844
My Jetpack: Add benefit-driven success messages for module activation #46251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
My Jetpack: Add benefit-driven success messages for module activation #46251
Conversation
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Code Coverage Summary1 file is newly checked for coverage.
Full summary · PHP report · JS report If appropriate, add one of these labels to override the failing coverage check:
Covered by non-unit tests
|
manzoorwanijk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let us retain the interpolation we had before to make translation easier.
projects/packages/my-jetpack/_inc/utils/module-benefit-messages.ts
Outdated
Show resolved
Hide resolved
projects/packages/my-jetpack/_inc/utils/module-benefit-messages.ts
Outdated
Show resolved
Hide resolved
|
Thanks so much for the thorough review, @manzoorwanijk! Pushing some changes right now. |
…checking Adding type-checking caught 'custom-content-types' not being shown in the modules list.
|
I added type-checking for the module slug in the list of benefits. It immediately caught an issue that 'custom-content-types' was not being shown in the modules list anywhere on My Jetpack. Thus, I added it to the list. |
manzoorwanijk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works great. Thank you. Please let me know if you need help merging/deploying this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR enhances the My Jetpack user experience by replacing generic module activation success messages with benefit-driven messages that emphasize the immediate value users receive when activating features.
Key changes:
- Created a new utility module (
module-benefit-messages.ts) with custom benefit messages for all 43 Jetpack modules - Updated
ModuleTogglecomponent to use the new benefit-driven messages for module activation - Added
custom-content-typesmodule to the system (previously missing from the constants)
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
projects/packages/my-jetpack/changelog/add-myjp-products-benefit-driven-activation-messages |
Standard changelog entry documenting this feature enhancement |
projects/packages/my-jetpack/_inc/utils/module-benefit-messages.ts |
New utility file containing 43 benefit-driven success messages and the activation message formatter function |
projects/packages/my-jetpack/_inc/constants.ts |
Added custom-content-types module to the JETPACK_NON_PAID_MODULES array |
projects/packages/my-jetpack/_inc/components/my-jetpack-tab-panel/products/mappings.ts |
Added custom-content-types module to the 'other' category for display in the products tab |
projects/packages/my-jetpack/_inc/components/module-toggle/index.tsx |
Updated to use new getModuleActivationMessage() function and fixed dependency array |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| * The benefit messages use present-tense descriptions of what the user NOW has. | ||
| * Messages are interpolated as: "%1$s activated! %2$s" where %1$s is the module | ||
| * name and %2$s is the benefit message. | ||
| * |
Copilot
AI
Dec 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR description states "all 41 Jetpack modules" but there are actually 43 modules being covered (36 non-paid + 7 paid). Please update the PR description to reflect the correct count of 43 modules.
| * | |
| * | |
| * Covers all 43 Jetpack modules (36 non-paid + 7 paid). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if we missed any 🤔
I think we are fine here, since we have a fallback.
projects/packages/my-jetpack/_inc/utils/module-benefit-messages.ts
Outdated
Show resolved
Hide resolved
projects/packages/my-jetpack/_inc/utils/module-benefit-messages.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <[email protected]>
|
Thanks, @manzoorwanijk ! I think this should be finally ready. |
Proposed changes:
Other information:
do not break them?
you'll see a generated comment below with a script to run)?
Jetpack product discussion
p1765329939935419-slack-C0D96691V
Does this pull request change what data or activity we track or use?
No
Testing instructions:
Expected behavior:
[Module name] activated! [Benefit].Before:
Generic message: "Image CDN has been activated."
After:
Benefit-driven message: "Image CDN activated! Your site now loads images faster
with automatic resizing from our global CDN."