Skip to content

Conversation

@Copons
Copy link
Contributor

@Copons Copons commented Dec 10, 2025

Fixes DOTTHEM-134

Proposed changes:

  • Refactor the editor-side Limited Global Styles notices to share actions across different notices.
  • Show upgrade, reset, and learn more actions in the "view canvas" notice (site editor black frame).
  • Replace the support link with a site editor link for resetting premium styles in the front end notice.
Before After
Screenshot 2025-12-10 at 17 51 41 Screenshot 2025-12-10 at 17 50 57
Screenshot 2025-12-10 at 17 51 31 Screenshot 2025-12-10 at 17 50 31

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack Dotcom product discussion

p58i-oLo-p2

Does this pull request change what data or activity we track or use?

No

Testing instructions:

Important

Automatticians only!

Warning

There's a bug in the "view canvas" that doesn't correctly persist global styles when switching to the "edit canvas". It seems to be a Dotcom-only bug, and it's unrelated to this change. We are investigating.

  • Sync these changes to the sandbox.
  • Sandbox a free site.
  • Enter the site editor and add some styles.
  • In the "view canvas" (black frame), ensure the Limited Global Styles notice shows these three actions: upgrade, reset, learn more.
  • Confirm they all do what they are supposed to do (open the Plans page in a new tab, reset any global styles, open the Help Center.
  • Check for regression: enter the "edit canvas" and try the three actions in the big Limited Global Styles notice, and confirm they work in the same way.
  • Move on to the front end.
  • In the admin bar's Limited Global Styles popover, click on the "Remove" link.
  • Confirm you are redirected to the site editor, in "view canvas" mode (black frame), with the Design panel opened.

@Copons Copons requested a review from a team December 10, 2025 18:05
@Copons Copons self-assigned this Dec 10, 2025
@Copons Copons added the [Status] Needs Review This PR is ready for review. label Dec 10, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 10, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@github-actions github-actions bot added [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. and removed [Status] Needs Review This PR is ready for review. labels Dec 10, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 10, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (WordPress.com Site Helper), and enable the dotthem-134-allow-users-to-remove-premium-styles-from-all-three-banners branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack-mu-wpcom-plugin dotthem-134-allow-users-to-remove-premium-styles-from-all-three-banners

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@jp-launch-control
Copy link

Code Coverage Summary

Coverage changed in 1 file.

File Coverage Δ% Δ Uncovered
projects/packages/jetpack-mu-wpcom/src/features/wpcom-global-styles/index.php 32/417 (7.67%) 0.13% -7 💚

Full summary · PHP report

@Copons Copons changed the title Limited Global Styles: Improve resetting flows Limited Global Styles: Improve reset flows Dec 10, 2025
@Copons Copons added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Review This PR is ready for review. and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Dec 12, 2025
Copy link
Contributor

@xavier-lc xavier-lc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works as described 👌

Image Image Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[mu wpcom Feature] Wpcom Global Styles [Package] Jetpack mu wpcom WordPress.com Features [Status] Needs Review This PR is ready for review. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants