Skip to content

Conversation

@vianasw
Copy link
Contributor

@vianasw vianasw commented Dec 11, 2025

Fixes FORMS-461

Proposed changes:

  • Bump mc stats on each webhook request, including the requests status (success, failed, error)

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Enable webhooks via the filter flag:
    add_filter( 'jetpack_forms_webhooks_enabled', '__return_true' );
  • Create a form and enable webhooks in the form settings.
  • Publish the post and submit a form response.
  • Check that the submission works correctly.

@vianasw vianasw added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] In Progress labels Dec 11, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 11, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the add/form-track-webhook-requests branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack add/form-track-webhook-requests

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@jp-launch-control
Copy link

jp-launch-control bot commented Dec 11, 2025

Code Coverage Summary

Coverage changed in 1 file.

File Coverage Δ% Δ Uncovered
projects/packages/forms/src/service/class-form-webhooks.php 86/90 (95.56%) 0.26% 0 💚

Full summary · PHP report · JS report

@vianasw vianasw self-assigned this Dec 12, 2025
@vianasw vianasw requested a review from a team December 12, 2025 16:40
@vianasw vianasw added [Status] Needs Review This PR is ready for review. and removed [Status] In Progress labels Dec 12, 2025
@vianasw vianasw force-pushed the add/form-track-webhook-requests branch from d3d9745 to baff56a Compare December 15, 2025 10:03
@vianasw vianasw merged commit 03af434 into trunk Dec 15, 2025
69 checks passed
@vianasw vianasw deleted the add/form-track-webhook-requests branch December 15, 2025 10:38
@github-actions github-actions bot removed the [Status] Needs Review This PR is ready for review. label Dec 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] Contact Form [Package] Forms [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants