(WIP) VideoPress: Make VideoPress depend on site connection instead of individual user Jetpack connections

[leonardost]

Fixes #39034

Proposed changes:

This PR update the VideoPress Gutenberg block to not gate uploads depending on individual user Jetpack connections. If the underlying site is connected to WPCOM and has the VideoPress plan, all users of that site should be able to upload videos to VIdeoPress regardless if they're individually connected to WPCOM or not.

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

• Spin up a site in jurassic.ninja with the Jetpack Beta plugin and the update/make-videopress-depend-on-site-connection-instead-of-individual-user branch selected for Jetpack VideoPress
  • You can do this by clicking on this URL https://jurassic.ninja/create?jetpack-beta&branches.jetpack-videopress=update/make-videopress-depend-on-site-connection-instead-of-individual-user
• Purchase the Jetpack VideoPress plan for that site by going to "Jetpack > VideoPress" and selecting "Get VideoPress"
• Connect the site's account with your WPCOM account
• Create a new post, add a VideoPress block and ensure it works normally
• Now add a new admin user to the site
• Log as that new user and ensure it can also add VideoPress blocks and upload videos without having to connect their account to WPCOM

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the update/make-videopress-depend-on-site-connection-instead-of-individual-user branch.
• To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack update/make-videopress-depend-on-site-connection-instead-of-individual-user

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• 🔴 Add a "[Status]" label (In Progress, Needs Review, ...).
  
• 🔴 Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• 🔴 Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

🔴 Action required: Please add missing changelog entries for the following projects: projects/packages/videopress

Use the Jetpack CLI tool to generate changelog entries by running the following command: jetpack changelog add.
Guidelines: /docs/writing-a-good-changelog-entry.md

---

Follow this PR Review Process:

1. Ensure all required checks appearing at the bottom of this PR are passing.
2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
3. You can use GitHub's Reviewers functionality to request a review.
4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

[jp-launch-control]

Code Coverage Summary

Coverage changed in 1 file.

File	Coverage	Δ%	Δ Uncovered
projects/packages/videopress/src/client/lib/connection/index.ts	0/26 (0.00%)	0.00%	8 💔

Full summary · PHP report · JS report

_{If appropriate, add one of these labels to override the failing coverage check: Covered by non-unit tests Use to ignore the Code coverage requirement check when E2Es or other non-unit tests cover the code Coverage tests to be added later Use to ignore the Code coverage requirement check when tests will be added in a follow-up PR I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage.}

[paulopmt1]

Thanks for working on this @leonardost. I'm happy you're prioritizing one of your learning goals!

I was able to successfully add a video in Gutenberg as a new Editor user without connecting to Jetpack from that new test user, which is great:

With that Editor permission, I cannot access Jetpack > VideoPress, which I believe is expected:

When I use this new user in the Administrator permission, I can access Jetpack > VideoPress, but cannot upload videos there or edit the current ones:

Can we also modify that check to allow the edition as we did in the Gutenberg block?

I was about to propose to solve the same issue for the VideoPress interface, but it seems we intentionally changed that here. More conetxt: p9dueE-69D-p2

So if that was intentional, why this Gutenberg block change works fine?

Can we test @leonardost if we could also update this logic to not check the user is connected?