Skip to content

Conversation

@markbiek
Copy link
Contributor

Related to WOOMKT-489

Proposed changes:

As part of 197866-ghe-Automattic/wpcom, we're adding the wccom_product_search_keywords field to Jetpack search.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Visual inspection should be fine.

@markbiek markbiek requested a review from fgiannar December 12, 2025 16:22
@markbiek markbiek self-assigned this Dec 12, 2025
@markbiek markbiek added the [Status] Needs Review This PR is ready for review. label Dec 12, 2025
@markbiek markbiek requested a review from gcsecsey December 12, 2025 16:23
@github-actions
Copy link
Contributor

github-actions bot commented Dec 12, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack or WordPress.com Site Helper), and enable the WOOMKT-489/wpbakery-search-issue branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack WOOMKT-489/wpbakery-search-issue
bin/jetpack-downloader test jetpack-mu-wpcom-plugin WOOMKT-489/wpbakery-search-issue

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions
Copy link
Contributor

github-actions bot commented Dec 12, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@github-actions github-actions bot added [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. and removed [Status] Needs Review This PR is ready for review. labels Dec 12, 2025
@markbiek markbiek added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Search Index Change labels Dec 12, 2025
@jp-launch-control
Copy link

jp-launch-control bot commented Dec 12, 2025

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

@markbiek markbiek force-pushed the WOOMKT-489/wpbakery-search-issue branch from 4cef41e to 6ac76e7 Compare December 12, 2025 21:05
Copy link
Contributor

@fgiannar fgiannar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@fgiannar fgiannar added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Dec 15, 2025
@markbiek markbiek merged commit e5d8a23 into trunk Dec 15, 2025
119 of 120 checks passed
@markbiek markbiek deleted the WOOMKT-489/wpbakery-search-issue branch December 15, 2025 15:14
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Dec 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Package] Sync [Status] Search Index Change [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants