-
Notifications
You must be signed in to change notification settings - Fork 844
My Jetpack: fix false "backup failed" error for deactivated backups #46299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
Code Coverage SummaryCoverage changed in 1 file.
|
Fixes BACKUP-298
When backups are intentionally deactivated (status:
backups-deactivated), My Jetpack shows "The last backup attempt failed" which is confusing because the backup isn't failing - it's just turned off.Proposed changes:
useGetReadableFailedBackupReason()hook instead of hardcoded "The last backup attempt failed"Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
tools/docker/mu-plugins/0-snippets.php:jetpack docker exec wp transient delete 'my-jetpack-backup-status'/wp-admin/admin.php?page=my-jetpack