POC: Sync Embedded Notifications Banner component on update #11027
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +259 B (0%) Total Size: 870 kB
ℹ️ View Unchanged
|
mordeth
commented
Aug 29, 2025
| @@ -201,7 +216,10 @@ const OverviewPage = () => { | |||
| } else { | |||
| // This is the case where we addressed everything and previously had some notifications to address. | |||
| // We recommend the merchant to reload the page in this case. | |||
| if ( stripeNotificationsCountToAddressMemo > 0 ) { | |||
| if ( | |||
There was a problem hiding this comment.
I managed to get the Refresh message to show once, but I still need to investigate why the component preloader is displayed twice on refresh.
There was a problem hiding this comment.
Ideally, this notification should be removed, and the account status block should be updated when a global event is fired after an embedded component is updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes WOOPLUG-5422
Changes proposed in this Pull Request
This PR introduces a proof-of-concept implementation of the Embedded Notifications Banner with synchronized state across multiple instances of the component. The goal is to ensure that when one banner is updated, the changes are immediately reflected in all other locations where it appears, in this case, both on the WooPayments > Overview page and inside the WooCommerce Activity Drawer.
Testing instructions
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge