Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use real Attchment types instead of Document #1486

Draft
wants to merge 6 commits into
base: trunk
Choose a base branch
from

Conversation

pfefferle
Copy link
Member

@pfefferle pfefferle commented Mar 20, 2025

Use Audio and Video instead of Document.

Proposed changes:

Other information:

  • Have you written new tests for your changes, if applicable?

Testing instructions:

  • Go to '..'

Changelog entry

  • Automatically create a changelog entry from the details below.
Changelog Entry Details

Significance

  • Patch
  • Minor
  • Major

Type

  • Added - for new features
  • Changed - for changes in existing functionality
  • Deprecated - for soon-to-be removed features
  • Removed - for now removed features
  • Fixed - for any bug fixes
  • Security - in case of vulnerabilities

Message

Use Audio and Video type for Attachments, instead of the very generic Document type.

@pfefferle pfefferle self-assigned this Mar 20, 2025
@pfefferle pfefferle requested a review from a team March 20, 2025 13:49
@obenland
Copy link
Member

Would a unit test help to make sure we get the expected output? Probably more cosmetics, as it's really more about third-party consumers understanding it correctly?

@pfefferle
Copy link
Member Author

We had some isses with attachments not showing up properly on Mastodon and I thought it might be because of them changing the requirments... but it seems to be not the solution to that because Mastodon is still using Document 🤔

@pfefferle pfefferle marked this pull request as draft March 21, 2025 09:40
@mattwiebe
Copy link
Contributor

I like the idea of sending proper Attachment types. But maybe not if it doesn't fix anything heh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants