Ensure correct visibility handling for Undo and Follow requests#1988
Merged
Ensure correct visibility handling for Undo and Follow requests#1988
Undo and Follow requests#1988Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes visibility handling for ActivityPub Undo and Follow requests to ensure proper privacy controls. The changes preserve original activity visibility when undoing actions and set appropriate privacy levels for follow requests.
- Preserve original activity visibility when creating
Undorequests - Set
Followrequests to use private visibility by default
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| includes/collection/class-outbox.php | Retrieves and preserves original activity visibility when creating undo operations |
| includes/collection/class-following.php | Sets follow requests to use private visibility constant |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure to retain the visibility settings of the original object when performing an
Undo, and sendFollowrequests only to the platform where the followed account resides.Proposed changes:
Undo.Followrequests with private visibility.Other information:
Testing instructions:
Changelog entry
Changelog Entry Details
Significance
Type
Message
Ensure correct visibility handling for
UndoandFollowrequests