Revert "Always remove filter maybe_double_knock http_response fil…

[pfefferle]

…ter! (#1986)"

This reverts commit 4d14174.

Fixes #

Proposed changes:

Other information:

• Have you written new tests for your changes, if applicable?

Testing instructions:

• Go to '..'

Changelog entry

• Automatically create a changelog entry from the details below.

Changelog Entry Details

Significance

• Patch
• Minor
• Major

Type

• Added - for new features
• Changed - for changes in existing functionality
• Deprecated - for soon-to-be removed features
• Removed - for now removed features
• Fixed - for any bug fixes
• Security - in case of vulnerabilities

Message

[Copilot]

Pull Request Overview

This PR reverts a previous commit that modified the placement of a filter removal in the maybe_double_knock method. The change moves the remove_filter call from the beginning of the method (after the early return check) back to its original position before the early return check.

• Restores the original filter removal timing in the HTTP signature handling logic

[Copilot]

Moving the filter removal after the early return check creates a potential issue. If the method returns early due to missing required parameters (line 90), the filter will never be removed, which could lead to the filter remaining active when it shouldn't be. The filter should be removed immediately at the start of the method to ensure it's always cleaned up regardless of execution path.

Suggested change

	// Bail if there's nothing to sign with. It's likely an unrelated request getting processed first.
	if ( ! isset( $args['key_id'], $args['private_key'], $args['headers']['Date'] ) ) {
	return $response;
	}
	// Remove this filter to prevent infinite recursion.
	\remove_filter( 'http_response', array( self::class, 'maybe_double_knock' ) );
	// Remove this filter to prevent infinite recursion.
	\remove_filter( 'http_response', array( self::class, 'maybe_double_knock' ) );
	// Bail if there's nothing to sign with. It's likely an unrelated request getting processed first.
	if ( ! isset( $args['key_id'], $args['private_key'], $args['headers']['Date'] ) ) {
	return $response;
	}