Fix fatal error when fetching remote author in embed handler #2681
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent "Cannot use object of type WP_Error as array" by initializing $author as an empty array upfront and only populating it if the HTTP request succeeds. This ensures $author is always an array, allowing the code to gracefully fall back when the remote request fails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent "Cannot use object of type WP_Error as array" by initializing $author as an empty array upfront and only populating it if the HTTP request succeeds. This ensures $author is always an array, allowing the code to gracefully fall back when the remote request fails.
Fixes #
Proposed changes:
Other information:
Testing instructions:
I believe this happens when Mastodon Posts are embedded in a Blog post via the Embed block and the remote server is too slow to answer.
Changelog entry