Skip to content

Remove validated form controls #105219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 15, 2025
Merged

Remove validated form controls #105219

merged 2 commits into from
Aug 15, 2025

Conversation

mirka
Copy link
Member

@mirka mirka commented Aug 14, 2025

Proposed Changes

Removes all the validated form control components from the repo.

Why are these changes being made?

Development of these components has now moved to the Gutenberg repo. At this time, usage should mostly be through DataForm, which can be bundled in any app.

Testing Instructions

No testing required — there are no actual usages in the app.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you tested accessibility for your changes? Ensure the feature remains usable with various user agents (e.g., browsers), interfaces (e.g., keyboard navigation), and assistive technologies (e.g., screen readers) (PCYsg-S3g-p2).
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@mirka mirka self-assigned this Aug 14, 2025
Copy link

github-actions bot commented Aug 14, 2025

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug remove-validated-form-controls on your sandbox.

@mirka mirka requested a review from a team August 14, 2025 23:45
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Aug 14, 2025
Copy link
Member

@jsnajdr jsnajdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 These controls were not used anywhere inside Calypso? Just exported in @automattic/components for consumers in other repos?

@mirka mirka merged commit 21b4430 into trunk Aug 15, 2025
14 checks passed
@mirka mirka deleted the remove-validated-form-controls branch August 15, 2025 15:29
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Aug 15, 2025
@mirka
Copy link
Member Author

mirka commented Aug 15, 2025

Just exported in @automattic/components for consumers in other repos?

They haven't even been exported at all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants