DateCalendar, DateRangeCalendar: use px instead of rem, use theme-ready variables #105264
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Note: This PR applies the same changes as in WordPress/gutenberg#71248
Switch from
rem
topx
units for some internal sizes (day button size, nav height, months gap).Why?
Until now, the
DateCalendar
andDateRangeCalendar
components would render in unexpected ways depending on the HTML base font size.The changes in this PR enforce the same metrics across environments with different base HTML font sizes.
How?
Switch from
rem
topx
, assuming a16px
base font size.Testing Instructions
Compare Storybook examples on trunk and this PR:
16px