Skip to content

Conversation

@mehmoodak
Copy link
Member

@mehmoodak mehmoodak commented Jan 29, 2026

Fixes: READ-275

Proposed Changes

  • Use Verbum Editor API middleware to forward all Quick Post embed requests to verbum API instead of looking for wp-json/oembed/1.0/proxy endpoint.
  • Fix Quick Post editor which limits the max height to 800px.

Why are these changes being made?

Verbum Editor by default looks for wp-json/oembed/1.0/proxy endpoint which doesn't work in Reader case so we are forwarding requests to the alternative /wpcom/v2/verbum/embed API.

Testing Instructions

  1. Go to /reader. Verify embed are not working in Quick Post.
  2. Checkout this Jetpack PR (Verbum Editor: Allow logged in users on /wpcom/v2/verbum/embed endpoint jetpack#46824) on sandbox if not merged.
  3. Checkout this PR or use Calypso Live.
  4. Verify that embeds are working fine now.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you tested accessibility for your changes? Ensure the feature remains usable with various user agents (e.g., browsers), interfaces (e.g., keyboard navigation), and assistive technologies (e.g., screen readers) (PCYsg-S3g-p2).
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@mehmoodak mehmoodak self-assigned this Jan 29, 2026
@matticbot
Copy link
Contributor

matticbot commented Jan 29, 2026

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Async-loaded Components (~963 bytes added 📈 [gzipped])

Details
name                                             parsed_size           gzip_size
async-load-calypso-reader-components-quick-post      +2246 B  (+0.1%)     +963 B  (+0.2%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@mehmoodak mehmoodak force-pushed the READ-275/fix-embeds-on-quick-post branch from 10e2324 to 3378ea3 Compare January 29, 2026 15:18
@matticbot
Copy link
Contributor

matticbot commented Jan 29, 2026

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • help-center
  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug READ-275/fix-embeds-on-quick-post on your sandbox.

@mehmoodak mehmoodak marked this pull request as ready for review January 30, 2026 09:52
@mehmoodak mehmoodak requested a review from a team as a code owner January 30, 2026 09:52
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 30, 2026
Copy link
Contributor

@gabrielcaires gabrielcaires left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked as expected!

Image

Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense. I did leave a comment in the Jetpack PR, but once that one is merged this should be good to go.

@mehmoodak mehmoodak force-pushed the READ-275/fix-embeds-on-quick-post branch from 6bc59b8 to c909be4 Compare February 3, 2026 07:10
@mehmoodak mehmoodak force-pushed the READ-275/fix-embeds-on-quick-post branch from ebe7577 to 7eea825 Compare February 3, 2026 09:47
@mehmoodak mehmoodak merged commit c9f354d into trunk Feb 4, 2026
12 checks passed
@mehmoodak mehmoodak deleted the READ-275/fix-embeds-on-quick-post branch February 4, 2026 06:20
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants