-
Notifications
You must be signed in to change notification settings - Fork 2k
Reader: Fix embeds on Quick Post #108422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reader: Fix embeds on Quick Post #108422
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Async-loaded Components (~963 bytes added 📈 [gzipped]) DetailsReact components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
10e2324 to
3378ea3
Compare
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
gabrielcaires
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jeherve
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sense. I did leave a comment in the Jetpack PR, but once that one is merged this should be good to go.
6bc59b8 to
c909be4
Compare
ebe7577 to
7eea825
Compare

Fixes: READ-275
Proposed Changes
wp-json/oembed/1.0/proxyendpoint.800px.Why are these changes being made?
Verbum Editor by default looks for
wp-json/oembed/1.0/proxyendpoint which doesn't work in Reader case so we are forwarding requests to the alternative/wpcom/v2/verbum/embedAPI.Testing Instructions
Pre-merge Checklist