-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A4A: Show a banner based on agency approval status #97708
base: trunk
Are you sure you want to change the base?
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~1880 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, it looks good. I have a few minor comments, but are non-blockers.
'We have not approved your application for the Automattic for Agencies program. Please {{a}}contact support{{/a}} to discuss this further if you think this was done in error.', | ||
{ | ||
components: { | ||
a: <a href="#contact-support" />, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use the CONTACT_URL_HASH_FRAGMENT
constant to replace '#contact-support'? This way, if we change the fragment, we only need to update one area.
if ( ! agency?.approval_status ) { | ||
return null; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can exclude this condition, as the following line covers this already. What do you think?
const bannerDetails = availableBannerDetails[ agency?.approval_status ];
if ( ! bannerDetails ) {
return null;
}
Related to https://github.com/Automattic/automattic-for-agencies-dev/issues/1608
PT: pfunGA-3ie-p2
Proposed Changes
Note: There's an existing issue for a layout bug when these banners are displayed on mobile screen sizes.
Why are these changes being made?
pending
,approved
, andrejected
./overview
;/marketplace/hosting/wpcom
- including hosting, products, and checkout pages;/sites
)Pending
Rejected
Approved
created_at
field, as described in the backend PR if your agency is older than 1 week.created_at
value to be older than 1 week. The banner should no longer be shown in this caseNote: You can clear the Calypso preference after closing the banner if need from the UI.
Testing Instructions
Pre-merge Checklist