A4A: Show a banner based on agency approval status#97708
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~1716 bytes added 📈 [gzipped]) DetailsSections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
client/a8c-for-agencies/components/a4a-agency-approval-notice/index.tsx
Outdated
Show resolved
Hide resolved
client/a8c-for-agencies/components/a4a-agency-approval-notice/index.tsx
Outdated
Show resolved
Hide resolved
bd7608b to
d27fd97
Compare
|
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17081164 Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday. Thank you @travisw for including a screenshot in the description! This is really helpful for our translators. |
|
Thanks for the feedback @jkguidaven! I've made a couple small updates. |
|
I'll merge this now. The banner won't ever show however until the backend PR has also been merged. |
|
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17081164 Some locales (Hebrew) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday. Thank you @travisw for including a screenshot in the description! This is really helpful for our translators. |
|
Translation for this Pull Request has now been finished. |
* show banner based on agency approval status * only show close button for approved; add styles * if status is approved only show banner for 1 week max * cleanup * add banner to sites and marketplace pages * use CONTACT_URL_HASH_FRAGMENT, simply approval_status check * also add notice to add payment method page
Related to https://github.com/Automattic/automattic-for-agencies-dev/issues/1608
PT: pfunGA-3ie-p2
Proposed Changes
Note: There's an existing issue for a layout bug when these banners are displayed on mobile screen sizes.
Why are these changes being made?
Testing Instructions
pending,approved, andrejected./overview;/marketplace/hosting/wpcom- including hosting, products, and checkout pages;/sites;/purchases/payment-methods/add)Pending
Rejected
Approved
created_atfield, as described in the backend PR if your agency is older than 1 week.created_atvalue to be older than 1 week. The banner should no longer be shown in this caseNote: You can clear the Calypso preference after closing the banner if need from the UI.
Pre-merge Checklist