Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domain management: Email: Create context menu component #97711

Open
wants to merge 11 commits into
base: trunk
Choose a base branch
from

Conversation

bogiii
Copy link
Contributor

@bogiii bogiii commented Dec 20, 2024

Closes #97284

Proposed Changes

  • Creates context menu component
  • Updates Header component to support the context menu
  • Integrates context menu

Why are these changes being made?

  • Domain Management Revamp

Testing Instructions

  • Go to /domains/manage?flags=calypso/all-domain-management
  • Ensure you have WP (titan) and Google domain created
  • Select WP domain and select Email tab
  • Check the context menu options, check if the links property works
Screenshot 2024-12-24 at 00 17 28
  • Select google domain
  • Check the context menu options, check if the links property works
Screenshot 2024-12-24 at 00 17 09
Current options and links
1 2

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@bogiii bogiii self-assigned this Dec 20, 2024
@matticbot
Copy link
Contributor

matticbot commented Dec 20, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~1726 bytes added 📈 [gzipped])

name     parsed_size           gzip_size
email        +5456 B  (+0.7%)    +1205 B  (+0.6%)
domains      +4768 B  (+0.2%)    +1012 B  (+0.2%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@bogiii bogiii force-pushed the update/domains-management-email-8 branch from 12aba69 to 84cbe49 Compare December 23, 2024 21:47
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/domains-management-email-8 on your sandbox.

@bogiii bogiii requested a review from a team December 23, 2024 23:25
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 23, 2024
@bogiii bogiii marked this pull request as ready for review December 23, 2024 23:26
@bogiii bogiii requested a review from a team as a code owner December 23, 2024 23:26
Copy link
Member

@merkushin merkushin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with Titan only at the moment. Asked Bogdan on how to test with Google in private messages.

One question here: is this email list component used only in our new UI?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add updated context menu to mailbox list items
3 participants