Me: Fix Background Height of Emptier Pages #97748
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Some of the pages on
/mehave looked quite odd for a while now because their height doesn't expand to the full screen, which has a weird effect when switching between pages.Why are these changes being made?
This line of code was removed in #94180 because it was considered unnecessary, but that was wrong - the code was preventing this issue from occurring. I have tried repeatedly to reproduce the bug that it was removed to fix (#94167), but I can't do so now.
Testing Instructions
Navigate some pages through
/meand verify:/me/privacyat all screen sizes.cc @eoigal, @Addison-Stavlo, @fushar