Domain management: Fix email management path when the feature flag is ON

[bogiii]

Closes #97623

Proposed Changes

• Fixes redirection issue

Why are these changes being made?

• Domain management revamp

Testing Instructions

• Open /domains/manage?flags=calypso/all-domain-management
• Select domain
• Add forward email
• Check if it redirects on email list

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-128459

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-128459&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-128459&env=a8c-for-agencies

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~14 bytes added 📈 [gzipped])

name                   parsed_size           gzip_size
entry-main                   +17 B  (+0.0%)      +10 B  (+0.0%)
entry-login                  +17 B  (+0.0%)      +10 B  (+0.0%)
entry-domains-landing        +17 B  (+0.0%)       +2 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~4 bytes added 📈 [gzipped])

name                  parsed_size           gzip_size
update-design-flow          +17 B  (+0.0%)       +4 B  (+0.0%)
link-in-bio-tld-flow        +17 B  (+0.0%)       +4 B  (+0.0%)
copy-site-flow              +17 B  (+0.0%)       +4 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~20 bytes added 📈 [gzipped])

name                                                                              parsed_size           gzip_size
async-load-signup-steps-page-picker                                                     +17 B  (+0.0%)       +3 B  (+0.0%)
async-load-signup-steps-domains                                                         +17 B  (+0.0%)       +5 B  (+0.0%)
async-load-purchase-modal-wrapper                                                       +17 B  (+0.0%)       +3 B  (+0.0%)
async-load-my-sites-checkout-purchase-modal-is-eligible-for-one-click-checkou...        +17 B  (+0.0%)       +3 B  (+0.0%)
async-load-calypso-my-sites-checkout-modal                                              +17 B  (+0.0%)      +12 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[matticbot]

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

• blaze-dashboard
• odyssey-stats

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/domains-management-email-9 on your sandbox.

[bogiii]

The similar approach as we did here:

wp-calypso/client/my-sites/email/paths.ts

Lines 79 to 83 in 1f1cfcb

	if ( isUnderDomainManagementAll( relativeTo ) ) {
	return `${ domainsManagementPrefix }/${ domainName }/forwarding/add/${ siteName }${ buildQueryString(
	urlParameters
	) }`;
	}

[Imran92]

LGTM 👍