Differentiate selected and hovered table rows #2675
Conversation
FlorianJacta
added
📈 Improvement
Pipfile
Outdated
There was a problem hiding this comment.
please don't modify building configuration
There was a problem hiding this comment.
a new example file should follow the same structure as the other ones (comments, run parameters ...)
| with tgb.Page() as page: | ||
| tgb.toggle(theme=True) | ||
|
|
||
| tgb.table("{data}", selected="{selected}", on_action=num_on_action) |
|
|
||
| tgb.table("{data}", selected="{selected}", on_action=num_on_action) | ||
|
|
||
| tgb.table("{data}", selected="{selected}", on_action=num_on_action, class_name="rows-similar rows-bordered") |
There was a problem hiding this comment.
default behavior should be the same as before so we don't have breaking changes ?
| @@ -73,3 +73,8 @@ | |||
| background: var(--color-background); | |||
| opacity: var(--table-stripe-opacity, 0.5); | |||
| } | |||
|
|
|||
| /* Override stripe opacity when row is selected */ | |||
| .taipy-table:where(:not(.rows-similar)) tbody tr.selected:nth-child(odd)::after { | |||
There was a problem hiding this comment.
default behavior should be the same as before so we don't have breaking changes ?
taipy.sqlite3.db
Outdated
|
This PR has been labelled as "🥶Waiting for contributor" because it has been inactive for more than 14 days. If you would like to continue working on this PR, then please add new commit or another comment, otherwise this PR will be closed in 14 days. For more information please refer to the contributing guidelines. |
github-actions
bot
added
the
🥶Waiting for contributor
github-actions
bot
removed
the
🥶Waiting for contributor
|
This PR has been labelled as "🥶Waiting for contributor" because it has been inactive for more than 14 days. If you would like to continue working on this PR, then please add new commit or another comment, otherwise this PR will be closed in 14 days. For more information please refer to the contributing guidelines. |
github-actions
bot
added
the
🥶Waiting for contributor
What type of PR is this? (Check all that apply)
Description
For tables with striped rows: selected rows will revert to 100% opacity (from 50%) to prevent confusion when hovering over adjacent rows. When a selected row is at 50% opacity, it is difficult to differentiate from a row which is being hovered over.
Related Tickets & Documents
How to reproduce the issue
Run table_example.py in taipy/doc/examples. Switch to light mode and select a striped row before hovering over the row above or below it.
Backporting
This change should be backported to:
Checklist
We encourage keeping the code coverage percentage at 80% or above.
If not, explain why:
Would still like to make additional changes
If not, explain why:
Would still like to make additional changes
If not, explain why:
Would still like to make additional changes
If not, explain why:
Would still like to make additional changes