[coop_badge_reader addon] Preserve aspect-ratio of badge image #1078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi David, your pull request has not submitted yet! |
|
I consider the PR done, but i don't know the contribution process so i chose to keep the PR as draft until i received a response Do you consider it ready for review? |
|
oh... i realize that neither the file i edited nor any of its parent directories, nor the repo have a licence #1079 Adding a licence is a solution. I can propose other solutions if adding a licence does not work |
|
Ok, from our side, your contribution has been tested, and ready to be merged. fyi, here is the process in general:
|
|
Sounds good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi :-)
I'm David, member of Superquinquin in Lille
My picture is all spread in the coop_badge_reader screen
Based on quick tests, it seems like
object-fit: contain;fixes the problemI'm new to the project, so i'm not familiar with the contribution process
I'm happy to improve this PR with guidance if it doesn't comply with current standards