Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(all): retry and clean queue system #77

Merged
merged 139 commits into from
Dec 31, 2024

Conversation

guillaume-chervet
Copy link
Collaborator

@guillaume-chervet guillaume-chervet commented Sep 18, 2024

  • fix: bug first call http scale 0 to 1
  • feature: add clean queue system
  • refactor: upgrade dependencies
  • feature: retry pattern now configurable

README.md Outdated
@@ -165,6 +168,8 @@ spec:
SlimFaas/SubscribeEvents: "Public:my-event-name1,Private:my-event-name2,my-event-name3" # comma separated list of event names
SlimFaas/DefaultVisibility: "Public" # Public or Private (private can be accessed only by internal namespace https call from pods)
SlimFaas/UrlsPathStartWithVisibility: "Private:/mypath/subPath,Private:/mysecondpath" # Public or Private (private can be accessed only by internal namespace https call from pods)
SlimFaas/SynchrounousRetry: "2;4;8"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to delete

@@ -168,14 +186,74 @@ public static Task ListLeftPush(HttpContext context)
});
}

public static int[] HttpStatusCodesWorthRetrying =
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to delete

@@ -279,8 +366,25 @@ private static void AddDeployments(string kubeNamespace, V1DeploymentList deploy
return new ScheduleConfig();
}

private static void AddStatefulSets(string kubeNamespace, V1StatefulSetList deploymentList, IEnumerable<PodInformation> podList,
IList<DeploymentInformation> deploymentInformationList, ILogger<KubernetesService> logger)
private static SlimFaasConfiguration GetConfiguration(IDictionary<string, string> annotations, string name, ILogger<KubernetesService> logger)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

finish if ressource version does not change keep previous version

@guillaume-chervet guillaume-chervet changed the title feat(all): retry with dead letter queue feat(all): retry and clean queue system Dec 31, 2024
@guillaume-chervet guillaume-chervet merged commit fda13cd into main Dec 31, 2024
2 checks passed
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
67.3% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant