ayatana-indicator-bluetooth: Add Bluetooth pairing agent #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Robert Tari <[email protected]> Signed-off-by: Muhammad Asif <[email protected]>
Signed-off-by: Muhammad Asif <[email protected]>
* Passkey/PIN display is slightly wonky right now, BlueZ doesn't call the Cancel() method once pairing is done, so you have to swipe away the notification manually. But apart from that, everything else works. Signed-off-by: Muhammad <[email protected]>
maciek134
reviewed
Jul 24, 2025
|
|
||
| public void RequestConfirmation (GLib.ObjectPath object, uint32 passkey) throws RejectedError, GLib.DBusError, GLib.IOError | ||
| { | ||
| string body = "Are you sure you want to pair with passkey %06u?".printf (passkey); |
There was a problem hiding this comment.
To avoid confusion with web passkeys, I think we should call both options "PIN" given that's how it's generally referred to
| } | ||
|
|
||
| if (have_actions) { | ||
| loop.run (); |
There was a problem hiding this comment.
I'm not too familiar with vala, won't this block? This could quickly turn into an unintended DoS - imo we should make sure this can concurrently process/reject other requests to avoid that
peat-psuwit
reviewed
Sep 1, 2025
Comment on lines
+105
to
+107
| public void AuthorizeService (GLib.ObjectPath object, string uuid) throws GLib.DBusError, GLib.IOError | ||
| { | ||
| } |
Contributor
There was a problem hiding this comment.
As it is, the (background) agent will now authorize any connection request from the other device, negating Bluez' "trusted" flag ("Connect automatically when detected" in lomiri-system-settings). Is that intended?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.