Use monaco-editor node package instead of CDN for offline editing #442
+11
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned by #368, the editor should be able to work offline. This PR adds monaco-editor as a dev dependency, and simlinks it into the public directory, so that the editor will work offline. It will continue to use the CDN if there is an internet connection.
Edit:
The github action for pull requests was running with pnpm version
8, while the version of pnpm listed inpackage.jsonis9.1.4. This caused a discrepancy when runningpnpm run linton a local machine versus on the github action, as on github it errors. I have also updated the workflow file to address this.