Skip to content

Conversation

@lorenzopalaia
Copy link
Contributor

Fix footer positioning in converter tool pages

Previously, there was an empty space below the footer on the converter tool pages. I adjusted the layout to ensure that the pages take up the full available space, keeping the footer properly attached to the bottom.

Additionally, I noticed that these pages are not fully responsive. This could be improved in a future update.

@AykutSarac
Copy link
Owner

I couldn't replicate the issue, can you share a screenshot please?

@lorenzopalaia
Copy link
Contributor Author

Sure!

Current behavior on prod:
Screenshot 2025-03-31 at 16 15 44

Fix:
Screenshot 2025-03-31 at 16 15 59

@lorenzopalaia
Copy link
Contributor Author

Just removed all the changes from the footer except the 100% width which I found was necessary to cover all the space

@AykutSarac
Copy link
Owner

Container width is 100% by default if IIRC, it's a div.

@lorenzopalaia
Copy link
Contributor Author

Based on testing, I found a few possible solutions:

  • w="100%" on the container
  • wrap the container with a parent div to make it take up the full width without w="100%"
  • mx={0} on the container since I understand there is a horizontal margin applied by default

Which one do you think is the most feasible? Third option looks a good tradeoff in my opinion.

@lorenzopalaia lorenzopalaia requested a review from AykutSarac April 9, 2025 17:16
@AykutSarac AykutSarac merged commit 89c29e9 into AykutSarac:main Apr 29, 2025
1 check passed
@lorenzopalaia lorenzopalaia deleted the sticky-footer branch April 29, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants