Skip to content

Allow to specify encoding when importing a file #514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+28 −7
Open

Allow to specify encoding when importing a file #514

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 28 additions & 7 deletions src/features/modals/ImportModal/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import React from "react";
import type { ModalProps } from "@mantine/core";
import { Modal, Group, Button, TextInput, Stack, Paper, Text } from "@mantine/core";
import { Modal, Group, Button, TextInput, Stack, Paper, Text, Select } from "@mantine/core";
import { Dropzone } from "@mantine/dropzone";
import { event as gaEvent } from "nextjs-google-analytics";
import toast from "react-hot-toast";
Expand All @@ -11,6 +11,14 @@ import useFile from "../../../store/useFile";
export const ImportModal = ({ opened, onClose }: ModalProps) => {
const [url, setURL] = React.useState("");
const [file, setFile] = React.useState<File | null>(null);
const [encoding, setEncoding] = React.useState("utf-8");

const encodingOptions = [
{ value: "utf-8", label: "UTF-8 (default)" },
{ value: "utf-16le", label: "UTF-16 LE" },
{ value: "utf-16be", label: "UTF-16 BE" },
{ value: "iso-8859-1", label: "ISO-8859-1 (Latin-1)" },
];

const setContents = useFile(state => state.setContents);
const setFormat = useFile(state => state.setFormat);
Expand All @@ -35,12 +43,19 @@ export const ImportModal = ({ opened, onClose }: ModalProps) => {
const format = file.name.substring(lastIndex + 1);
setFormat(format as FileFormat);

file.text().then(text => {
setContents({ contents: text });
setFile(null);
setURL("");
onClose();
});
file
.arrayBuffer()
.then(buffer => {
const decoder = new TextDecoder(encoding);
const text = decoder.decode(buffer);
setContents({ contents: text });
setFile(null);
setURL("");
onClose();
})
.catch(() => {
toast.error(`Failed to decode file using ${encoding}`);
});

gaEvent("import_file", { label: format });
}
Expand Down Expand Up @@ -88,6 +103,12 @@ export const ImportModal = ({ opened, onClose }: ModalProps) => {
</Stack>
</Dropzone>
</Paper>
<Select
label="File Encoding"
data={encodingOptions}
value={encoding}
onChange={value => value && setEncoding(value)}
/>
</Stack>
<Group justify="right">
<Button onClick={handleImportFile} disabled={!(file || url)}>
Expand Down