Skip to content

hard code diagnostic logging #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tonybaloney merged 1 commit into from
May 6, 2024
Merged

hard code diagnostic logging #75

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions {{cookiecutter.__src_folder_name}}/infra/core/host/appservice.bicep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@ param runtimeName string
param runtimeNameAndVersion string = '${runtimeName}|${runtimeVersion}'
param runtimeVersion string

param enableDiagnosticLogging bool = true

// Microsoft.Web/sites Properties
param kind string = 'app,linux'

Expand Down Expand Up @@ -61,9 +59,9 @@ resource appService 'Microsoft.Web/sites@2022-03-01' = {
allowedOrigins: union([ 'https://portal.azure.com', 'https://ms.portal.azure.com' ], allowedOrigins)
}
// Diagnostic logging
detailedErrorLoggingEnabled: enableDiagnosticLogging
httpLoggingEnabled: enableDiagnosticLogging
requestTracingEnabled: enableDiagnosticLogging
detailedErrorLoggingEnabled: true
Copy link
Contributor

@pamelafox pamelafox May 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, will you be suggesting this change for azure-dev? Or it was needed here for some reason, you couldnt pass in true? Ah you're trying to make template-analyzer happy, I guess?

httpLoggingEnabled: true
requestTracingEnabled: true
}
clientAffinityEnabled: clientAffinityEnabled
httpsOnly: true
Expand Down