Refactor Product API endpoints and enhance testing #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DETAILS Refactored the `ProductEndpoints` class to utilize methods from `ProductApiActions` and `ProductAiActions`, enhancing code organization and separation of concerns. Updated endpoint mappings to call the new methods for retrieving, updating, creating, deleting, and searching products. Added new asynchronous methods in `ProductApiActions.cs` for handling product logic and introduced the `AISearch` method in `ProductAiActions.cs` for AI search functionality. Overall, the structure is cleaner and more maintainable.
DETAILS - Updated `eShopLite-Aspire.sln` to include "4 Tests" project and reference for "Products.Tests". - Modified `MSTestSettings.cs` to enable parallel test execution. - Added `ProductApiActionsTests` class with a method to verify seeded products in `GetAllProducts`. - Created `Products.Tests.csproj` with necessary SDK and dependencies for testing.
DETAILS This commit introduces new unit tests in `ProductApiActionsTests.cs` to improve coverage for product-related API actions, including methods for retrieving, creating, updating, deleting, and searching for products. Each test utilizes an in-memory database with a unique name for isolation. Additionally, the `UpdateProduct` method in `ProductApiActions.cs` has been updated to fetch the existing product before applying changes, ensuring correct operation and returning a `NotFound` result if the product does not exist.
|
👋 Thanks for contributing @elbruno! We will review the pull request and get back to you soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the
ProductEndpointsclass for better organization and separation of concerns by utilizing methods fromProductApiActionsandProductAiActions. Introduce new unit tests for product-related API actions, improving test coverage and organization. Update logic inProductApiActionsto ensure correct operation when updating products.