Improving readability of scenario 7 #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
aaronpowell
commented
Jun 23, 2025
aaronpowell
commented
- Moving to slnx from sln
- Updated docs
- Simplification of the agent codebase to improve discoverability and support running locally
…upport running locally * The changes introduce a new agent-based architecture for insights generation using Microsoft Semantic Kernel, with dedicated agent classes for sentiment and language detection, and a new extension method for registering these agents and the generator in the DI container. * The Generator class is refactored to use dependency injection for agents and logging, removing direct agent instantiation and improving orchestration. * The OpenAI client and embedding generator setup in both Insights and Products projects is modernized to use Azure Identity and configuration-based deployment names, supporting better cloud integration and local development. * The memory context in Products is refactored to use new AI interfaces, with improved prompt handling and logging. * Endpoint mapping in Insights is updated to use static lambdas and typed results for clarity and performance. * The solution file now includes the README.md as a solution item. * The README.md is updated to clarify configuration steps, correct project names, and provide improved instructions for setting up Azure OpenAI connections and telemetry. * OpenTelemetry configuration is enhanced to include additional meters and sources for better observability, including experimental AI metrics.
|
👋 Thanks for contributing @aaronpowell! We will review the pull request and get back to you soon. |
Check Country Locale in URLsWe have automatically detected added country locale to URLs in your files. Check the file paths and associated URLs inside them.
|
Check Broken URLsWe have automatically detected the following broken URLs in your files. Review and fix the paths to resolve this issue. Check the file paths and associated broken URLs inside them.
|
There was a problem hiding this comment.
Pull Request Overview
This PR standardizes solution files to the new .slnx format, updates documentation links, and refactors the agent codebase (scenario 7) to use dependency injection, primary constructors, and modern Azure OpenAI client patterns for improved local development and discoverability.
- Converted legacy
.slnfiles to<Solution>XML (.slnx) and removed old.slnclutter - Updated README.md pointers to
.slnxfiles across scenarios - Simplified Azure OpenAI client configuration and refactored agent/MemoryContext classes to leverage DI and raw string literals
Reviewed Changes
Copilot reviewed 36 out of 36 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| scenarios/08-Sql2025/src/eShopLite-Sql2025.slnx | Added new XML-based solution file .slnx |
| scenarios/08-Sql2025/README.md | Updated solution link to point at .slnx |
| scenarios/07-AgentsConcurrent/src/eShopServiceDefaults/Extensions.cs | Added telemetry instrumentation for Experimental.Microsoft.Extensions.AI |
| scenarios/07-AgentsConcurrent/src/eShopAppHost/Program.cs | Introduced conditional OpenAI connection logic |
| scenarios/07-AgentsConcurrent/src/Products/Memory/MemoryContext.cs | Refactored class to primary constructor and raw prompt literal |
Comments suppressed due to low confidence (3)
scenarios/07-AgentsConcurrent/src/eShopAppHost/Program.cs:54
- The variable
aoaiis not defined in this scope, which will cause a compilation error. Replaceaoaiwith the correct reference returned by yourAddAzureOpenAIClientcall or declare it earlier.
openai = aoai;
scenarios/07-AgentsConcurrent/src/Products/Memory/MemoryContext.cs:17
- [nitpick] Raw string literals preserve leading whitespace in each line; the indentation here will be sent to the model. Consider aligning the delimiters or trimming indentation so the prompt is formatted cleanly.
private const string _systemPrompt = """
scenarios/07-AgentsConcurrent/src/eShopServiceDefaults/Extensions.cs:74
- [nitpick] Confirm that the meter/source name matches the actual library's SDK namespace. If the instrumentation targets
Microsoft.Extensions.AI, update the meter name accordingly to ensure telemetry is captured.
.AddMeter("Experimental.Microsoft.Extensions.AI");
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.