enable workloadidentity for AIO #188
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jagadishmurugan
commented
Jun 26, 2024
jagadishmurugan
commented
Jun 26, 2024
seanyen
reviewed
Jun 26, 2024
seanyen
reviewed
Jun 26, 2024
seanyen
reviewed
Jun 26, 2024
seanyen
reviewed
Jun 26, 2024
|
I can see you add the code to consume the private bits and enable workload identity when Arc connecting the cluster. LGTM. |
sixtycents
reviewed
Jul 2, 2024
| [string] $Tag, | ||
| # Temporary params for private bits | ||
| [Parameter(Mandatory=$true)] | ||
| [string] $connectedK8sPrivateWhlPath, |
There was a problem hiding this comment.
We cannot let customer to enter this parameter if we ship this script to customers.
There was a problem hiding this comment.
this wont be merged to main (merged to a private integration branch already) - this is intended only for internal testing and needed to test private Arc bits.
the two parameters will not be needed in the final version and code around private bits will also be removed
sixtycents
reviewed
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verification steps:
Note: This change is not intended to be committed as it uses private bits. Once the prod bits from Arc team is available, we should make minor modifications to use the correct arc module versions and change repo/tag back point to Azure (main fork).