Skip to content

feat: Q2 FY25 Policy Refresh #957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 37 commits into from
Feb 22, 2025
Merged

feat: Q2 FY25 Policy Refresh #957

merged 37 commits into from
Feb 22, 2025

Conversation

cae-pr-creator[bot]
Copy link
Contributor

@cae-pr-creator cae-pr-creator bot commented Feb 13, 2025

Overview/Summary

This pull request includes several updates to policy assignments and documentation within the Azure Landing Zones (ALZ) Bicep repository. The changes primarily involve renaming variables and updating policy definition versions.

Documentation updates:

Policy assignment updates:

These changes ensure consistency in variable naming and keep the policy definitions up to date with the latest versions.

Related Issues/Work Items

Closes #952
Closes #959
Fixes AB#38989

This PR fixes/adds/changes/removes

  1. Q2 2025 Policy Refresh
  2. Cleanup of unnecessary AMA permissions

Breaking Changes

Notice: Breaking Changes in Bicep Module Configuration

As part of the migration to user-defined types (UDTs) for properties within the parVpnGatewayConfig and parExpressRouteGatewayConfig parameters, the following breaking changes have been introduced:

1. Supported SKUs Limited to Availability Zones

The list of supported SKUs for VPN and ExpressRoute gateways now only includes those with availability zones. This change aligns with the consolidation and migration updates outlined in the official Azure documentation. For more details, refer to the Gateway SKU Consolidation and Migration Guide.

2. Property Name Alignment for parVpnGatewayConfig

The generation property in parVpnGatewayConfig has been renamed to vpnGatewayGeneration to align with the schema property name already used for parExpressRouteGatewayConfig.

3. Case Sensitivity of bgpSettings

The bgpsettings property is now case-sensitive and must be written as bgpSettings.

Subproperty Changes:
  • The asn and peerweight subproperties within bgpSettings now require integer values instead of strings, ensuring consistency with the resource schema.

Please update your configurations accordingly to avoid deployment errors.

Testing Evidence

Replace this with any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).

As part of this Pull Request I have

Base automatically changed from oZakari-patch-1 to main February 13, 2025 01:09
@oZakari oZakari added Type: Feature Request ➕ New feature or request Type: Bug 🪲 Something isn't working Area: Policy 📝 Issues / PR's related to Policy labels Feb 13, 2025
@oZakari oZakari had a problem deploying to BicepUpdateDocumentation February 13, 2025 03:26 — with GitHub Actions Failure
@oZakari oZakari had a problem deploying to BicepUpdateDocumentation February 13, 2025 03:27 — with GitHub Actions Failure
@oZakari oZakari had a problem deploying to BicepUpdateDocumentation February 13, 2025 03:28 — with GitHub Actions Failure
@oZakari oZakari had a problem deploying to BicepUpdateDocumentation February 13, 2025 18:49 — with GitHub Actions Failure
@oZakari oZakari had a problem deploying to BicepUpdateDocumentation February 13, 2025 19:50 — with GitHub Actions Failure
@oZakari oZakari changed the title feat: Update Policy Library (automated) feat: Q2 2025 Policy Refresh Feb 14, 2025
@oZakari oZakari had a problem deploying to BicepUpdateDocumentation February 14, 2025 02:38 — with GitHub Actions Failure
@oZakari oZakari changed the title feat: Q2 2025 Policy Refresh feat: Q2 FY25 Policy Refresh Feb 14, 2025
@oZakari oZakari had a problem deploying to BicepUpdateDocumentation February 14, 2025 02:39 — with GitHub Actions Failure
@oZakari oZakari had a problem deploying to BicepUpdateDocumentation February 17, 2025 05:54 — with GitHub Actions Failure
@oZakari oZakari had a problem deploying to BicepUpdateDocumentation February 17, 2025 05:58 — with GitHub Actions Failure
@oZakari oZakari had a problem deploying to BicepUpdateDocumentation February 17, 2025 05:59 — with GitHub Actions Failure
@oZakari oZakari temporarily deployed to BicepUpdateDocumentation February 17, 2025 06:02 — with GitHub Actions Inactive
@oZakari oZakari had a problem deploying to BicepUpdateDocumentation February 20, 2025 19:16 — with GitHub Actions Failure
@oZakari oZakari had a problem deploying to BicepUpdateDocumentation February 20, 2025 19:51 — with GitHub Actions Failure
@oZakari oZakari had a problem deploying to BicepUpdateDocumentation February 20, 2025 19:54 — with GitHub Actions Failure
@oZakari oZakari had a problem deploying to BicepUpdateDocumentation February 20, 2025 20:51 — with GitHub Actions Failure
@oZakari oZakari had a problem deploying to BicepUpdateDocumentation February 20, 2025 20:55 — with GitHub Actions Failure
@oZakari oZakari had a problem deploying to BicepUpdateDocumentation February 20, 2025 21:19 — with GitHub Actions Failure
@oZakari oZakari temporarily deployed to BicepUpdateDocumentation February 20, 2025 21:47 — with GitHub Actions Inactive
@oZakari
Copy link
Contributor

oZakari commented Feb 20, 2025

/azp run validateazcloud

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@oZakari oZakari temporarily deployed to BicepUpdateDocumentation February 20, 2025 23:47 — with GitHub Actions Inactive
Copy link
Collaborator

@jtracey93 jtracey93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @oZakari

@oZakari
Copy link
Contributor

oZakari commented Feb 21, 2025

/azp run validateazcloud

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@oZakari
Copy link
Contributor

oZakari commented Feb 22, 2025

/azp run valdiateazcloud

Copy link

No pipelines are associated with this pull request.

@oZakari oZakari merged commit e3ce5d5 into main Feb 22, 2025
14 of 16 checks passed
@oZakari oZakari deleted the patch-policy-library branch February 22, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Policy 📝 Issues / PR's related to Policy Type: Bug 🪲 Something isn't working Type: Feature Request ➕ New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Azure Policy] - Update to Policy Definition breaks Enforce-Encryption-CMK Policy Set Possible unnecessary permission assignments for Policy
3 participants