Skip to content

refactor: Disable automation account by default #980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 13, 2025
Merged

refactor: Disable automation account by default #980

merged 4 commits into from
Mar 13, 2025

Conversation

oZakari
Copy link
Contributor

@oZakari oZakari commented Mar 12, 2025

Overview/Summary

Disable Automation account by default and updates api version for the resource as well.

Related Issues/Work Items

Fixes AB#38768

This PR fixes/adds/changes/removes

Key changes include:

  • Added a new parameter parAutomationAccountEnabled to control the deployment of the Automation Account. [1] [2] [3]
  • Updated the resource version for resAutomationAccount to 2024-10-23 and conditioned its deployment based on the new parameter.
  • Modified the output variables outAutomationAccountName and outAutomationAccountId to handle cases where the Automation Account is not deployed by returning null.

Breaking Changes

  1. None

Testing Evidence

image

As part of this Pull Request I have

@oZakari oZakari had a problem deploying to BicepUpdateDocumentation March 12, 2025 20:51 — with GitHub Actions Failure
@oZakari oZakari had a problem deploying to BicepUpdateDocumentation March 12, 2025 20:55 — with GitHub Actions Failure
@oZakari oZakari had a problem deploying to BicepUpdateDocumentation March 12, 2025 20:55 — with GitHub Actions Failure
@oZakari oZakari had a problem deploying to BicepUpdateDocumentation March 12, 2025 20:55 — with GitHub Actions Failure
@oZakari oZakari had a problem deploying to BicepUpdateDocumentation March 12, 2025 20:55 — with GitHub Actions Failure
@oZakari oZakari had a problem deploying to BicepUpdateDocumentation March 12, 2025 20:55 — with GitHub Actions Failure
@oZakari oZakari had a problem deploying to BicepUpdateDocumentation March 12, 2025 20:55 — with GitHub Actions Failure
@oZakari oZakari had a problem deploying to BicepUpdateDocumentation March 12, 2025 20:55 — with GitHub Actions Failure
@oZakari oZakari had a problem deploying to BicepUpdateDocumentation March 12, 2025 20:55 — with GitHub Actions Failure
@oZakari oZakari temporarily deployed to BicepUpdateDocumentation March 12, 2025 21:05 — with GitHub Actions Inactive
@oZakari oZakari changed the title Disable automation account by default refactor: Disable automation account by default Mar 12, 2025
@oZakari oZakari had a problem deploying to BicepUpdateDocumentation March 12, 2025 21:06 — with GitHub Actions Failure
@oZakari oZakari had a problem deploying to BicepUpdateDocumentation March 12, 2025 21:06 — with GitHub Actions Failure
@azure-boards azure-boards bot had a problem deploying to BicepUpdateDocumentation March 12, 2025 21:06 Failure
@oZakari oZakari added the Area: Logging & Automation 📷 Issues / PR's related to Logging & Automation label Mar 12, 2025
@oZakari oZakari had a problem deploying to BicepUpdateDocumentation March 12, 2025 21:07 — with GitHub Actions Failure
@oZakari oZakari had a problem deploying to BicepUpdateDocumentation March 12, 2025 21:07 — with GitHub Actions Failure
@oZakari oZakari temporarily deployed to BicepUpdateDocumentation March 13, 2025 02:20 — with GitHub Actions Inactive
@oZakari
Copy link
Contributor Author

oZakari commented Mar 13, 2025

/azp run validateazcloud

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@oZakari oZakari added the auto-merge ✔️ Automatically merges label Mar 13, 2025
Copy link
Member

@Springstone Springstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oZakari oZakari merged commit fe20f5b into main Mar 13, 2025
15 checks passed
@oZakari oZakari deleted the remove-aa branch March 13, 2025 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Logging & Automation 📷 Issues / PR's related to Logging & Automation auto-merge ✔️ Automatically merges
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants