Skip to content

feat: Add option to change vwan type #983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 20, 2025
Merged

feat: Add option to change vwan type #983

merged 3 commits into from
Mar 20, 2025

Conversation

oZakari
Copy link
Contributor

@oZakari oZakari commented Mar 20, 2025

Overview/Summary

This pull request introduces a new parameter parVirtualWanType to the vwanConnectivity module. This parameter allows users to specify the type of Virtual WAN to create, enhancing the configurability of the module.

Key changes include:

Documentation Update:

  • Added documentation for the new parVirtualWanType parameter in vwanConnectivity.bicep.md.

Parameter Files Update:

  • Added parVirtualWanType with a default value of "Standard" in mc-vwanConnectivity.parameters.all.json.
  • Added parVirtualWanType with a default value of "Standard" in vwanConnectivity.parameters.all.json.
  • Added parVirtualWanType with a default value of "Standard" in vwanConnectivity.parameters.az.all.json.
  • Added parVirtualWanType with a default value of "Standard" in vwanConnectivity.parameters.az.multiRegion.all.json.

Bicep File Update:

  • Introduced the parVirtualWanType parameter and updated the Virtual WAN resource to use this parameter in vwanConnectivity.bicep. [1] [2]

Related Issues/Work Items

N/A

This PR fixes/adds/changes/removes

  1. Adds param to change VWAN type

Breaking Changes

None

Testing Evidence

Replace this with any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).

As part of this Pull Request I have

@oZakari oZakari had a problem deploying to BicepUpdateDocumentation March 20, 2025 03:38 — with GitHub Actions Failure
@oZakari oZakari had a problem deploying to BicepUpdateDocumentation March 20, 2025 03:39 — with GitHub Actions Failure
@oZakari oZakari added the Area: Networking 🌐 Issues / PR's related to Networking label Mar 20, 2025
@oZakari oZakari temporarily deployed to BicepUpdateDocumentation March 20, 2025 03:42 — with GitHub Actions Inactive
@oZakari oZakari closed this Mar 20, 2025
@oZakari oZakari reopened this Mar 20, 2025
@oZakari oZakari temporarily deployed to BicepUpdateDocumentation March 20, 2025 03:50 — with GitHub Actions Inactive
@oZakari oZakari merged commit b456d1e into main Mar 20, 2025
11 checks passed
@oZakari oZakari deleted the feat-add-vwan-option branch March 20, 2025 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Networking 🌐 Issues / PR's related to Networking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant