feat: add ability to override varManagementGroupIds values in alzDefaultPolicyAssignments.bicep & workloadSpecificPolicyAssignments.bicep to support rename of ALZ default MGs and fix #986

[jtracey93]

Overview/Summary

Add ability to override varManagementGroupIds values in alzDefaultPolicyAssignments.bicep & workloadSpecificPolicyAssignments.bicep to support rename of ALZ default MGs

Useful for scenarios when renaming ALZ default management groups names and IDs but not their intent or hierarchy structure.

Also fix #986

Breaking Changes

None

Testing Evidence

Default logic, no inputs provided to new parameter

inputs provided to new parameter to override MG IDs

note the values for landingZonesCorp & landingZonesOnline

As part of this Pull Request I have

• Read the Contribution Guide and ensured this PR is compliant with the guide
• Ensured the resource API versions in .bicep file/s I am adding/editing are using the latest API version possible
• Checked for duplicate Pull Requests
• Associated it with relevant GitHub Issues
• (ALZ Bicep Core Team Only) Associated it with relevant ADO Items
• Ensured my code/branch is up-to-date with the latest changes in the main branch
• Performed testing and provided evidence.
• Updated one or more of the following tests (if required)
  • Unit
  • Linting
  • E2E (End-To-End)
  • ValidateAzCloud (Base validation in Azure Cloud)
  • ValidateMcCloud (Base validation in Azure China Cloud)
• Updated relevant and associated documentation (e.g. Contribution Guide, Module READMEs, Wiki Docs etc.)
• If relevant, created or updated Code Tours here

[Copilot]

Pull Request Overview

This PR adds the ability to override default management group IDs for ALZ policies, supporting scenarios where ALZ default management groups are renamed.

• Added a new parameter (parManagementGroupIdOverrides) and updated the generated documentation in both alzDefaultPolicyAssignments.bicep.md and workloadSpecificPolicyAssignments.bicep.md.
• Enhanced the parameter descriptions and snippets to include guidance on providing custom management group IDs.

Reviewed Changes

Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.

File	Description
infra-as-code/bicep/modules/policy/assignments/alzDefaults/generateddocs/alzDefaultPolicyAssignments.bicep.md	Added documentation for the new override parameter
infra-as-code/bicep/modules/policy/assignments/workloadSpecificPolicyAssignments.bicep.md	Added documentation for the new override parameter

Files not reviewed (2)

• infra-as-code/bicep/modules/policy/assignments/alzDefaults/alzDefaultPolicyAssignments.bicep: Language not supported
• infra-as-code/bicep/modules/policy/assignments/workloadSpecific/workloadSpecificPolicyAssignments.bicep: Language not supported

Comments suppressed due to low confidence (2)

infra-as-code/bicep/modules/policy/assignments/alzDefaults/generateddocs/alzDefaultPolicyAssignments.bicep.md:34

• [nitpick] Consider renaming the parameter to use the plural form (e.g., parManagementGroupIdsOverrides) to better match the referenced variable (varManagementGroupIds) and update the description for clarity (e.g., include a possessive apostrophe in 'management groups' names').

parManagementGroupIdOverrides | Yes      | Specify the ALZ Default Management Group IDs to override as specified in `varManagementGroupIds`. Useful for scenarios when renaming ALZ default management groups names and IDs but not their intent or hierarchy structure.

infra-as-code/bicep/modules/policy/assignments/workloadSpecific/generateddocs/workloadSpecificPolicyAssignments.bicep.md:18

• [nitpick] Consider renaming the parameter to use the plural form (e.g., parManagementGroupIdsOverrides) to align with the referenced variable (varManagementGroupIds) and consider updating the description to improve clarity by using the possessive form for 'management groups' names'.

parManagementGroupIdOverrides | Yes      | Specify the ALZ Default Management Group IDs to override as specified in `varManagementGroupIds`. Useful for scenarios when renaming ALZ default management groups names and IDs but not their intent or hierarchy structure.

[jtracey93]

/azp run validateazcloud

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[oZakari]

LGTM

[azure-pipelines]

Command 'validate' is not supported by Azure Pipelines.

Supported commands

• help:
• Get descriptions, examples and documentation about supported commands
• Example: help "command_name"
• list:
• List all pipelines for this repository using a comment.
• Example: "list"
• run:
• Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run.
• Example: "run" or "run pipeline_name, pipeline_name, pipeline_name"
• where:
• Report back the Azure DevOps orgs that are related to this repository and org
• Example: "where"

See additional documentation.

[oZakari]

/azp run validateazcloud

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[oZakari]

/azp run validateazcloud

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[oZakari]

/azp run validateazcloud

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).