Skip to content

Commit

Permalink
test use string
Browse files Browse the repository at this point in the history
  • Loading branch information
Jonathan Chang committed Dec 18, 2024
1 parent 605108c commit 33ae0ac
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion config/config.msft.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ defaults:
istioctlVersion: "1.24.1"
tag: "prod-stable"
targetVersion: "asm-1-23"
versions: ["\"asm-1-22\", \"asm-1-23\""]
versions: "\"asm-1-22\", \"asm-1-23\""

# MGMT cluster specifics
mgmt:
Expand Down
2 changes: 1 addition & 1 deletion config/config.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -675,7 +675,7 @@
},
"versions": {
"description": "The current istio version in the AKS cluster",
"type": "array"
"type": "string"
},
"targetVersion": {
"description": "The target istio version that will be updated to",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
using '../templates/svc-cluster.bicep'

param kubernetesVersion = '{{ .kubernetesVersion }}'
param istioVersion = [{{ .svc.istio.versions }}]
param istioVersion = ['{{ .svc.istio.versions }}']
param vnetAddressPrefix = '{{ .vnetAddressPrefix }}'
param subnetPrefix = '{{ .subnetPrefix }}'
param podSubnetPrefix = '{{ .podSubnetPrefix }}'
Expand Down
2 changes: 1 addition & 1 deletion dev-infrastructure/modules/aks-cluster-base.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,7 @@ resource aksCluster 'Microsoft.ContainerService/managedClusters@2024-04-02-previ
}
]
}
revisions: istioVersion[0]
revisions: istioVersion
}
}
: null
Expand Down

0 comments on commit 33ae0ac

Please sign in to comment.