Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use istio tag instead of version for namespace labeling #1021

Merged
merged 1 commit into from
Jan 7, 2025
Merged

use istio tag instead of version for namespace labeling #1021

merged 1 commit into from
Jan 7, 2025

Conversation

geoberle
Copy link
Collaborator

What this PR does

  • use istio tag from config.yaml for namespace tagging (frontend, backend, maestro, cluster-service)
  • run istio script as part of makefile driven svc cluster provisioning

Jira:
Link to demo recording:

Special notes for your reviewer

jonathan34c
jonathan34c previously approved these changes Dec 27, 2024
View reviewed changes
Copy link
Contributor

@jonathan34c jonathan34c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

SudoBrendan
SudoBrendan previously approved these changes Jan 2, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 6, 2025

Please rebase pull request.

@geoberle geoberle dismissed stale reviews from SudoBrendan and jonathan34c via 5d54609 January 7, 2025 09:26
@geoberle geoberle merged commit 89d3608 into main Jan 7, 2025
10 checks passed
@geoberle geoberle deleted the istio-tagging branch January 7, 2025 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janboll janboll janboll approved these changes

@SudoBrendan SudoBrendan SudoBrendan left review comments

@jonathan34c jonathan34c jonathan34c left review comments

@bennerv bennerv Awaiting requested review from bennerv bennerv is a code owner

@mbarnes mbarnes Awaiting requested review from mbarnes mbarnes is a code owner

@jmelis jmelis Awaiting requested review from jmelis jmelis is a code owner

@UlrichSchlueter UlrichSchlueter Awaiting requested review from UlrichSchlueter UlrichSchlueter is a code owner

@weinong weinong Awaiting requested review from weinong weinong is a code owner

@whober0521 whober0521 Awaiting requested review from whober0521 whober0521 is a code owner

@tony-schndr tony-schndr Awaiting requested review from tony-schndr tony-schndr is a code owner

@jharrington22 jharrington22 Awaiting requested review from jharrington22 jharrington22 is a code owner

@zgalor zgalor Awaiting requested review from zgalor zgalor is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@geoberle @janboll @jonathan34c @SudoBrendan