provision shard config generation in helm chart #1051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoberle
requested review from
bennerv,
jharrington22,
SudoBrendan,
UlrichSchlueter and
zgalor
as code owners
moving the provision shard config generation is required mostly due to a technical limitation of templatize right now. short-term the provision shard config will vanish for in-cluster deployments as shards will need to be brought in by a registration API. Signed-off-by: Gerd Oberlechner <[email protected]>
geoberle
force-pushed
the
cs-deploy-shard-cfg-generation
branch
from
c339fcf to
b766e05
Compare
tony-schndr
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
moving the provision shard config generation is required mostly due to a technical limitation of templatize right now.
to be specific: generating the provision shard calls templatize during a pipeline run and requires the DEPLOY_ENV variable, which is not available in that context.
short-term the provision shard config will vanish for in-cluster deployments as shards will need to be brought in by a registration API.
Jira:
Link to demo recording:
Special notes for your reviewer