Conversation
|
Please rebase pull request. |
janboll
requested review from
SudoBrendan,
UlrichSchlueter,
bennerv,
geoberle,
jharrington22,
jmelis,
jonathan34c,
tony-schndr,
weinong,
whober0521 and
zgalor
as code owners
| roleRef: | ||
| apiGroup: rbac.authorization.k8s.io | ||
| kind: ClusterRole | ||
| name: cluster-admin |
There was a problem hiding this comment.
Is there a more fine grained role we could use?
There was a problem hiding this comment.
I used the same role used by the PKO team: https://github.com/package-operator/package-operator/blob/f564bbba288a9e3748c871c0eaec329de2ec4cd2/config/self-bootstrap-job.yaml.tpl#L16
So I'll have to ask, if we can reduce the access.
There was a problem hiding this comment.
i think it also comes down to what packages this PKO instance will manage. as we develop a feeling about what kind of resources RVMO will bring in, we could narrow the role towards that.
There was a problem hiding this comment.
Agreed, cause the service account assigned to is used by the operator during runtime.
geoberle
left a comment
geoberle
left a comment
There was a problem hiding this comment.
LGTM
afaiu the slack thread with the PKO folks, they are thinking about the removal of the image pin, hence we might be able to avoid our own build in the future
3 participants
What this PR does
Jira:
Link to demo recording:
Special notes for your reviewer