remove custom ACR role for token management #1075
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoberle
requested review from
SudoBrendan,
UlrichSchlueter,
bennerv,
janboll,
jmelis,
jonathan34c,
tony-schndr,
weinong and
whober0521
as code owners
custom roles are heavily limited in MSFT tenants, therefore we will leverage the built-in `Container Registry Contributor and Data Access Configuration Administrator` role consistently in all environments instead. Signed-off-by: Gerd Oberlechner <[email protected]>
geoberle
force-pushed
the
remove-acr-custom-role
branch
from
f8e8c97 to
84a18e0
Compare
tony-schndr
approved these changes
Jan 15, 2025
jonathan34c
pushed a commit
that referenced
this pull request
Jan 29, 2025
custom roles are heavily limited in MSFT tenants, therefore we will leverage the built-in `Container Registry Contributor and Data Access Configuration Administrator` role consistently in all environments instead. Signed-off-by: Gerd Oberlechner <[email protected]>
katherinelc321
pushed a commit
to katherinelc321/ARO-HCP
that referenced
this pull request
Jan 30, 2025
custom roles are heavily limited in MSFT tenants, therefore we will leverage the built-in `Container Registry Contributor and Data Access Configuration Administrator` role consistently in all environments instead. Signed-off-by: Gerd Oberlechner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
custom roles are heavily limited in MSFT tenants, therefore we will leverage the built-in
Container Registry Contributor and Data Access Configuration Administratorrole consistently in all environments instead.this role is a bit more priviliged than necessary but still not as powerful as
Contributor- also: we will not be flagged for using this roleJira: https://issues.redhat.com/browse/ARO-7453
Link to demo recording:
Special notes for your reviewer