local_CS_script_fix to properly create provision shard config file in CS directory #1079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidleerh
requested review from
bennerv,
geoberle,
janboll,
jmelis,
jonathan34c,
SudoBrendan,
UlrichSchlueter,
weinong,
whober0521 and
tony-schndr
as code owners
|
/lgtm |
|
closing in favor of: #1080 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR makes changes so that it generates the provision shard config file in CS directory properly by pointing to the correct makefile target/command; when running CS locally.
Fixing the issue where the target/command "provision-shard" does not exist under /ARO-HCP/cluster-service/Makefile.
Changes ->
From: "provision-shard"
To: "local-deploy-provision-shard"
In addition, updating the cloud-region-constraints yaml file name to the correct name and to the correct directory:
From: "./configs/cloud-resources/cloud-regions-constraints.yaml"
To: "./configs/cloud-resource-constraints/cloud-region-constraints.yaml"
(conforming with check via
"https://github.com/Azure/ARO-HCP/blob/main/dev-infrastructure/local_CS.sh#L39")
After the infrastructure was deployed with command:
"SKIP_CONFIRM=1 make infra.all deployall"
The above changes were required to successfully connect with the provision shard as well as setting the cloud_regions "westus3" to be enabled in the local instance/run of clusters service.
Jira: N/A
Link to demo recording: N/A
Special notes for your reviewer
N/A