Conversation
mgahagan73
added
hold
mgahagan73
requested review from
bennerv,
deads2k,
jharrington22,
mbukatov and
patriksuba
as code owners
|
/test stage-e2e-parallel |
|
/test integration-e2e-parallel |
mbukatov
left a comment
mbukatov
left a comment
There was a problem hiding this comment.
Suggesting to simplify deployment phase.
|
Please rebase pull request. |
|
/test integration-e2e-parallel |
|
/test prod-e2e-parallel |
mgahagan73
changed the title
| // per test initialization | ||
| }) | ||
|
|
||
| It("should be able to create an HCP cluster and manage pull secrets", |
There was a problem hiding this comment.
What is specific about this flow for ARO HCP? If nothing, this looks like an end-to-end test for HyperShift functionality. Why should we run it in our suite?
There was a problem hiding this comment.
This e2e test covers ARO HCP feature ARO-21429, as documented in ARO HCP doc draft. And while most of the changes happened in HyperShift as you say, we find it important to be covered by E2E test.
|
Please rebase pull request. |
|
/test images |
|
/test e2e-parallel |
|
/hold cancel |
|
So the test works after refactoring based on testing locally, but it looks like we lost the extra secret repo when we changed the pre-merge test jobs around. |
|
/hold cancel |
|
/test e2e-parallel |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mgahagan73 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/test e2e-parallel |
2 similar comments
|
/test e2e-parallel |
|
/test e2e-parallel |
|
/test e2e-parallel |
|
replaced by #3637 due to merge conflicts. |
6 participants
https://issues.redhat.com/browse/ARO-20543
What
create cluster then use kubernetes API to update the global pull secret, verify pull secret was updated.
Why
confirm pull secret update functionallity.