Skip to content

Conversation

@mbarnes
Copy link
Collaborator

@mbarnes mbarnes commented Nov 15, 2025

ARO-22328 - E2E Test Suite: Support global autoscaling configuration

What

Jira indicates @shitaljante may already be working on this. I'll sync with her to see where she's at with it. For now this is just a stash of what I had previously written.

@openshift-ci
Copy link

openshift-ci bot commented Nov 15, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@shitaljante
Copy link
Collaborator

This PR is currently blocked by the update functionality introduced in #3541

Copy link
Collaborator

@SudoBrendan SudoBrendan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Overall, things are looking pretty good.

  1. I think there's a few minor bugs to address
  2. More importantly, we need to double-check that all of these timeouts are correct. The current test execution time of just this suite is something like 3-5 hours if we're hitting those timeout conditions.

Matthew Barnes and others added 5 commits December 18, 2025 11:24
@shitaljante shitaljante force-pushed the e2e/global-autoscaling branch from db7d7db to 9f806c2 Compare December 18, 2025 05:55
@shitaljante
Copy link
Collaborator

/test e2e-parallel

Copy link
Collaborator Author

@mbarnes mbarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't approve this since I originally submitted the PR.

I think this is overall good for a first pass. Some parts of this just look like it's testing validation, which I don't think E2E is the right context for. We have unit and simulation tests for validation testing.

The last test ("it should respect cluster-wide node limits with nodepool autoscaling") is the most important since it tests the interaction between cluster-wide autoscaling parameters and node pools. We could use more test cases that demonstrate this interaction, but this one case is good enough to prove the values are getting down to the customer cluster.

@geoberle
Copy link
Collaborator

/lgtm
/approve

@openshift-ci
Copy link

openshift-ci bot commented Dec 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: geoberle, mbarnes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mbarnes mbarnes dismissed SudoBrendan’s stale review December 23, 2025 13:00

Requests appear to have been addressed. Dismissing to allow merging.

@openshift-merge-bot openshift-merge-bot bot merged commit 4db1389 into main Dec 23, 2025
22 checks passed
@openshift-merge-bot openshift-merge-bot bot deleted the e2e/global-autoscaling branch December 23, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants