Skip to content

ARO-22851 parametrize ocp versions #3592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 4 commits into from
Dec 24, 2025
Merged

ARO-22851 parametrize ocp versions #3592

openshift-merge-bot merged 4 commits into from
Dec 24, 2025

Conversation

@mbukatov
Copy link
Collaborator

@mbukatov mbukatov commented Dec 14, 2025 •
edited by openshift-ci bot
Loading

ARO-22851

What

  • removing OpenShift version IDs from the test code
  • provide a way to redefine it from the outside
  • update the default to 4.20 (for testing purposes)

Why

We want to be able to redefine default OpenShift version we test with easily.

Special notes for your reviewer

WIP

@openshift-ci
Copy link

openshift-ci bot commented Dec 14, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@mbukatov
Copy link
Collaborator Author

mbukatov commented Dec 14, 2025

/test e2e-parallel

@mbukatov
Copy link
Collaborator Author

mbukatov commented Dec 15, 2025

/test integration-e2e-parallel

@mbukatov
Copy link
Collaborator Author

mbukatov commented Dec 15, 2025

/test e2e-parallel

JameelB
JameelB reviewed Dec 16, 2025
View reviewed changes
@mbukatov mbukatov force-pushed the ARO-22851-parametrize-ocp-versions branch from 296c62e to 5c486f8 Compare December 17, 2025 18:33
@mbukatov mbukatov self-assigned this Dec 17, 2025
@mbukatov
Copy link
Collaborator Author

mbukatov commented Dec 17, 2025

/test e2e-parallel

@mbukatov
Copy link
Collaborator Author

mbukatov commented Dec 17, 2025

/test integration-e2e-parallel

@mbukatov mbukatov force-pushed the ARO-22851-parametrize-ocp-versions branch from 5c486f8 to e0e5f5e Compare December 17, 2025 19:50
@mbukatov
Copy link
Collaborator Author

mbukatov commented Dec 17, 2025

/test integration-e2e-parallel

@mbukatov
Copy link
Collaborator Author

mbukatov commented Dec 17, 2025

/test e2e-parallel

@mbukatov
Copy link
Collaborator Author

mbukatov commented Dec 18, 2025

/test integration-e2e-parallel

@miquelsi miquelsi self-assigned this Dec 19, 2025
@miquelsi miquelsi force-pushed the ARO-22851-parametrize-ocp-versions branch from e0e5f5e to fb0fcf8 Compare December 19, 2025 09:59
@miquelsi miquelsi marked this pull request as ready for review December 19, 2025 10:17
@miquelsi
Copy link
Collaborator

miquelsi commented Dec 19, 2025

/test stage-e2e-parallel

1 similar comment
@davidffrench
Copy link
Collaborator

davidffrench commented Dec 19, 2025

/test stage-e2e-parallel

@miquelsi miquelsi added the lgtm label Dec 19, 2025
@miquelsi
Copy link
Collaborator

miquelsi commented Dec 23, 2025

/test stage-e2e-parallel

@miquelsi
Copy link
Collaborator

miquelsi commented Dec 23, 2025

/test prod-e2e-parallel

@raelga
Copy link
Collaborator

raelga commented Dec 23, 2025

/approve

@openshift-ci
Copy link

openshift-ci bot commented Dec 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mbukatov, raelga

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@raelga
Copy link
Collaborator

raelga commented Dec 23, 2025

/retest

@raelga
Copy link
Collaborator

raelga commented Dec 23, 2025

/test e2e-parallel

@raelga
Copy link
Collaborator

raelga commented Dec 23, 2025

/test integration-e2e-parallel

@raelga
Copy link
Collaborator

raelga commented Dec 23, 2025

/test e2e-parallel

@raelga
Copy link
Collaborator

raelga commented Dec 23, 2025

/test integration-e2e-parallel
/test e2e-parallel

@raelga
Copy link
Collaborator

raelga commented Dec 23, 2025

/test integration-e2e-parallel

@raelga
Copy link
Collaborator

raelga commented Dec 23, 2025

/test e2e-parallel

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 24, 2025

/retest-required

Remaining retests: 0 against base HEAD 4db1389 and 2 for PR HEAD fb0fcf8 in total

@sclarkso
Copy link
Collaborator

sclarkso commented Dec 24, 2025

/test integration-e2e-parallel
/test e2e-parallel

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 24, 2025

/retest-required

Remaining retests: 0 against base HEAD c9b360e and 1 for PR HEAD fb0fcf8 in total

@sclarkso
Copy link
Collaborator

sclarkso commented Dec 24, 2025

/test e2e-parallel

1 similar comment
@sclarkso
Copy link
Collaborator

sclarkso commented Dec 24, 2025

/test e2e-parallel

@raelga
Copy link
Collaborator

raelga commented Dec 24, 2025

/test integration-e2e-parallel

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 24, 2025

/retest-required

Remaining retests: 0 against base HEAD 8e7b7fa and 0 for PR HEAD fb0fcf8 in total

@openshift-ci
Copy link

openshift-ci bot commented Dec 24, 2025 •
edited
Loading

@mbukatov: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/integration-e2e-parallel fb0fcf8 link false /test integration-e2e-parallel

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit fde866d into main Dec 24, 2025
24 of 25 checks passed
@openshift-merge-bot openshift-merge-bot bot deleted the ARO-22851-parametrize-ocp-versions branch December 24, 2025 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JameelB JameelB JameelB left review comments

@deads2k deads2k Awaiting requested review from deads2k

@venkateshsredhat venkateshsredhat Awaiting requested review from venkateshsredhat

Assignees

@miquelsi miquelsi

@mbukatov mbukatov

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@mbukatov @miquelsi @davidffrench @raelga @openshift-ci-robot @sclarkso @JameelB