test/util: retry connection failures in dev #3611
Conversation
stevekuznetsov
force-pushed
the
skuznets/e2e-client-retry
branch
from
0beeab3 to
7145f60
Compare
|
fix the cap and if it works it lgtm |
stevekuznetsov
force-pushed
the
skuznets/e2e-client-retry
branch
2 times, most recently
from
e83678f to
128c5e7
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, stevekuznetsov The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
stevekuznetsov
force-pushed
the
skuznets/e2e-client-retry
branch
from
128c5e7 to
7a78133
Compare
|
New changes are detected. LGTM label has been removed. |
stevekuznetsov
force-pushed
the
skuznets/e2e-client-retry
branch
3 times, most recently
from
632b8ff to
8cebefb
Compare
Our connection strategy from the test runner to the service cluster can be unreliable, as it's fairly naive - we just run `oc port-forward`. Let's retry connection failures to ameliorate issues stemming from this. Signed-off-by: Steve Kuznetsov <[email protected]>
stevekuznetsov
force-pushed
the
skuznets/e2e-client-retry
branch
from
8cebefb to
c475ca4
Compare
|
/retest |
|
@stevekuznetsov: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Our connection strategy from the test runner to the service cluster can be unreliable, as it's fairly naive - we just run
oc port-forward. Let's retry connection failures to ameliorate issues stemming from this.