refactor: refactor helpers for admit cluster tests #3628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
/retest |
mbarnes
requested changes
Dec 18, 2025
Collaborator
mbarnes
left a comment
mbarnes
left a comment
There was a problem hiding this comment.
Thanks for the follow-up. I had a suggestion below to simplify a little.
Signed-off-by: Alba Hita Catala <[email protected]>
ahitacat
force-pushed
the
ahitacat-refactor-admit-cluster-test
branch
from
ab87d23 to
88ded9a
Compare
mbarnes
approved these changes
Dec 23, 2025
Collaborator
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahitacat, mbarnes The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Contributor
openshift-merge-bot
bot
deleted the
ahitacat-refactor-admit-cluster-test
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Refactor the helper method used in admit_cluster_test, now this test will use the methods in testhelpers.
Why
Follow up the comment #3140 (comment)