Migration of credential operation functions into framework #3635
Conversation
Add helper function wrappers for HCP SDK credential operations. Implement both wait and no-wait variants of functions. Refactor admin credential lifecycle test case. https://issues.redhat.com/browse/ARO-23093
|
Skipping CI for Draft Pull Request. |
mvacula02
requested review from
mbukatov,
mgahagan73,
miquelsi and
patriksuba
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mgahagan73, mvacula02 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/test e2e-parallel |
test/util/framework/hcp_helper.go
Outdated
| resourceGroupName string, | ||
| hcpClusterName string, | ||
| ) (*runtime.Poller[hcpsdk20240610preview.HcpOpenShiftClustersClientRequestAdminCredentialResponse], error) { | ||
| return hcpClient.BeginRequestAdminCredential(ctx, resourceGroupName, hcpClusterName, nil) |
There was a problem hiding this comment.
this appears to simply wrap a one-line call in a different one-line call. This is a bad pattern.
test/util/framework/hcp_helper.go
Outdated
| resourceGroupName string, | ||
| hcpClusterName string, | ||
| ) (*runtime.Poller[hcpsdk20240610preview.HcpOpenShiftClustersClientRevokeCredentialsResponse], error) { | ||
| return hcpClient.BeginRevokeCredentials(ctx, resourceGroupName, hcpClusterName, nil) |
There was a problem hiding this comment.
same comment about questionable alias value and indirection
test/util/framework/hcp_helper.go
Outdated
| ProvisioningStateSucceeded = hcpsdk20240610preview.ProvisioningStateSucceeded | ||
| ProvisioningStateFailed = hcpsdk20240610preview.ProvisioningStateFailed | ||
| ProvisioningStateCanceled = hcpsdk20240610preview.ProvisioningStateCanceled |
There was a problem hiding this comment.
Don't vanity alias a constant.
|
New changes are detected. LGTM label has been removed. |
|
/test e2e-parallel |
ARO-23093
What
Add helper wrappers for HCP SDK credential operation functions to the test framework:
BeginRequestAdminCredential()
BeginRevokeCredentials()
Implement both wait and no-wait variants of both functions for future use.
Refactor admin credential lifecycle test, which uses credential operation functions.
Why
Explained in the JIRA ticket.