Skip to content

Add more approvers for RP code directories #3656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mbarnes wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add more approvers for RP code directories #3656

mbarnes wants to merge 1 commit into from
+8 −2

Conversation

@mbarnes
Copy link
Collaborator

@mbarnes mbarnes commented Dec 18, 2025 •
edited
Loading

Also remove Maitiu Ciarain (mociarain) who is no longer on ARO-HCP.

@openshift-ci openshift-ci bot requested review from deads2k and geoberle December 18, 2025 13:10
@geoberle
Copy link
Collaborator

geoberle commented Dec 18, 2025

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Dec 18, 2025
@openshift-ci
Copy link

openshift-ci bot commented Dec 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: geoberle, mbarnes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@SudoBrendan
Copy link
Collaborator

SudoBrendan commented Dec 18, 2025

/test e2e-parallel

@stevekuznetsov
Copy link
Contributor

stevekuznetsov commented Dec 18, 2025

/hold

For the same reasons articulated in #3599 (comment)

Add more approvers for RP code directories
3bf87f3 
- Tanmay Satam (tsatam)
- Rajdeep Chauhan (rajdeepc2792)

Also remove Maitiu Ciarain (mociarain) who is no longer on ARO-HCP.
@mbarnes mbarnes force-pushed the add-approvers-for-1p branch from 8d04e0b to 3bf87f3 Compare December 18, 2025 16:53
@openshift-ci openshift-ci bot removed the lgtm label Dec 18, 2025
@openshift-ci
Copy link

openshift-ci bot commented Dec 18, 2025

New changes are detected. LGTM label has been removed.

@openshift-ci
Copy link

openshift-ci bot commented Dec 18, 2025

@mbarnes: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/periodic-images 3bf87f3 link true /test periodic-images

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@geoberle geoberle Awaiting requested review from geoberle

Assignees

@geoberle geoberle

Labels

approved do-not-merge/hold

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mbarnes @geoberle @SudoBrendan @stevekuznetsov